| 5 May 2023 |
kranzes | Not sure im not familiar with mindthegapps, i only used nikgapps | 16:25:39 |
matthewcroughan - nix.zone | robotnix-lineage_dreamlte> device/samsung/universal8895-common/BoardConfigCommon.mk:150: error: device/samsung_slsi/sepolicy/sepolicy.mk: No such file or directory | 16:38:03 |
matthewcroughan - nix.zone | ah damn, build failure | 16:38:08 |
matthewcroughan - nix.zone | dunno why it's going into samsung_slsi | 16:38:36 |
matthewcroughan - nix.zone | Ah I named a folder wrong | 16:38:49 |
matthewcroughan - nix.zone | Ah that still seems wrong though | 16:40:03 |
matthewcroughan - nix.zone | https://github.com/LineageOS/android_device_samsung_slsi_sepolicy | 16:43:48 |
matthewcroughan - nix.zone | Ah.. apparently needs this inserted into source.dirs | 16:43:54 |
matthewcroughan - nix.zone | After I'm done here, I wonder if we should make some sort of meta-support in Robotnix where we can share these source.dirs definitions so we can say we support various devices? | 16:46:49 |
matthewcroughan - nix.zone | * After I'm done here, I wonder if we should make some sort of meta-support in Robotnix where we can share these source.dirs definitions so we can say we support various devices that aren't supported upstream? | 16:46:55 |
silent_water | you can add a device like the pixel configuration is done under modules/ | 16:47:37 |
matthewcroughan - nix.zone | The problem would be bumping/maintaining the revs | 16:48:34 |
matthewcroughan - nix.zone | Ideally they'd be a flake with flake inputs that could be nix flake updated | 16:48:44 |
matthewcroughan - nix.zone | they always refer to a branch like lineage-19.1 and a nix flake update would handle that nicely | 16:49:05 |
matthewcroughan - nix.zone | I don't see this looking very good unless robotnix adopted flake.parts, as the flake.nix would just contain a massive amount of inputs | 16:49:50 |
matthewcroughan - nix.zone | I heard tomberek was working on builtin nix functions that would allow you to read a flake lock file and stuff, so maybe that could be good | 16:50:09 |
matthewcroughan - nix.zone | Atemu:
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read SYSTEM/etc/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read VENDOR/etc/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read VENDOR/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read PRODUCT/etc/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read PRODUCT/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read SYSTEM_EXT/etc/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read SYSTEM_EXT/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read ODM/etc/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read ODM/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read VENDOR_DLKM/etc/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read VENDOR_DLKM/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read ODM_DLKM/etc/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read ODM_DLKM/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Unable to get boot image build props: Failed to run command '['unpack_bootimg', '--boot_img', '/build/boot.img6r1N0V', '--out', '/build/boot_L78I4b.img']' (exit code 1):
dreamlte-ota_update> Traceback (most recent call last):
dreamlte-ota_update> File "/nix/store/mvnw94935qphb1z1bhv0a8vdbvaz3rmz-ota-tools/bin/unpack_bootimg/internal/stdlib/runpy.py", line 197, in _run_module_as_main
dreamlte-ota_update> File "/nix/store/mvnw94935qphb1z1bhv0a8vdbvaz3rmz-ota-tools/bin/unpack_bootimg/internal/stdlib/runpy.py", line 87, in _run_code
dreamlte-ota_update> File "/nix/store/mvnw94935qphb1z1bhv0a8vdbvaz3rmz-ota-tools/bin/unpack_bootimg/__main__.py", line 12, in <module>
dreamlte-ota_update> File "/nix/store/mvnw94935qphb1z1bhv0a8vdbvaz3rmz-ota-tools/bin/unpack_bootimg/internal/stdlib/runpy.py", line 197, in _run_module_as_main
dreamlte-ota_update> File "/nix/store/mvnw94935qphb1z1bhv0a8vdbvaz3rmz-ota-tools/bin/unpack_bootimg/internal/stdlib/runpy.py", line 87, in _run_code
dreamlte-ota_update> File "/nix/store/mvnw94935qphb1z1bhv0a8vdbvaz3rmz-ota-tools/bin/unpack_bootimg/unpack_bootimg.py", line 547, in <module>
dreamlte-ota_update> File "/nix/store/mvnw94935qphb1z1bhv0a8vdbvaz3rmz-ota-tools/bin/unpack_bootimg/unpack_bootimg.py", line 543, in main
dreamlte-ota_update> File "/nix/store/mvnw94935qphb1z1bhv0a8vdbvaz3rmz-ota-tools/bin/unpack_bootimg/unpack_bootimg.py", line 474, in unpack_image
dreamlte-ota_update> File "/nix/store/mvnw94935qphb1z1bhv0a8vdbvaz3rmz-ota-tools/bin/unpack_bootimg/unpack_bootimg.py", line 215, in unpack_boot_image
dreamlte-ota_update> UnicodeDecodeError: 'utf-8' codec can't decode byte 0xcc in position 532: invalid continuation byte
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Can't find META/ab_partitions.txt
dreamlte-ota_update> Compressing system.new.dat with brotli
| 17:50:00 |
matthewcroughan - nix.zone | ever seen this before? | 17:50:03 |
matthewcroughan - nix.zone | It didn't trigger an exit code greater than 0 so the drv built successfully | 17:50:18 |
matthewcroughan - nix.zone | that seems like a bug | 17:50:20 |
matthewcroughan - nix.zone | robotnix-lineage_dreamlte> 2023-05-05 17:38:04 - common.py - WARNING : Unable to get boot image build props: Failed to run command '['unpack_bootimg', '--boot_img', '/build/out/target/product/
dreamlte/obj/PACKAGING/target_files_intermediates/lineage_dreamlte-target_files-2022110721/IMAGES/boot.img', '--out', '/build/out/soong/.temp/boot_lrtOGc.img']' (exit code 1):
robotnix-lineage_dreamlte> Traceback (most recent call last):
robotnix-lineage_dreamlte> File "/build/out/host/linux-x86/bin/unpack_bootimg/internal/stdlib/runpy.py", line 197, in _run_module_as_main
robotnix-lineage_dreamlte> File "/build/out/host/linux-x86/bin/unpack_bootimg/internal/stdlib/runpy.py", line 87, in _run_code
robotnix-lineage_dreamlte> File "/build/out/host/linux-x86/bin/unpack_bootimg/__main__.py", line 12, in <module>
robotnix-lineage_dreamlte> File "/build/out/host/linux-x86/bin/unpack_bootimg/internal/stdlib/runpy.py", line 197, in _run_module_as_main
robotnix-lineage_dreamlte> File "/build/out/host/linux-x86/bin/unpack_bootimg/internal/stdlib/runpy.py", line 87, in _run_code
robotnix-lineage_dreamlte> File "/build/out/host/linux-x86/bin/unpack_bootimg/unpack_bootimg.py", line 547, in <module>
robotnix-lineage_dreamlte> File "/build/out/host/linux-x86/bin/unpack_bootimg/unpack_bootimg.py", line 543, in main
robotnix-lineage_dreamlte> File "/build/out/host/linux-x86/bin/unpack_bootimg/unpack_bootimg.py", line 474, in unpack_image
robotnix-lineage_dreamlte> File "/build/out/host/linux-x86/bin/unpack_bootimg/unpack_bootimg.py", line 215, in unpack_boot_image
robotnix-lineage_dreamlte> UnicodeDecodeError: 'utf-8' codec can't decode byte 0xcc in position 532: invalid continuation byte
robotnix-lineage_dreamlte> 2023-05-05 17:38:04 - common.py - WARNING : Can't find META/ab_partitions.txt
robotnix-lineage_dreamlte> 2023-05-05 17:38:04 - add_img_to_target_files.py - INFO :
robotnix-lineage_dreamlte> ++++ boot ++++
robotnix-lineage_dreamlte> 2023-05-05 17:38:04 - common.py - INFO : using prebuilt boot.img from BOOTABLE_IMAGES...
robotnix-lineage_dreamlte> 2023-05-05 17:38:04 - add_img_to_target_files.py - INFO :
robotnix-lineage_dreamlte> ++++ recovery ++++
robotnix-lineage_dreamlte> 2023-05-05 17:38:04 - common.py - INFO : using prebuilt recovery.img from BOOTABLE_IMAGES...
robotnix-lineage_dreamlte> 2023-05-05 17:38:04 - add_img_to_target_files.py - INFO :
robotnix-lineage_dreamlte> ++++ recovery (two-step image) ++++
robotnix-lineage_dreamlte> 2023-05-05 17:38:04 - common.py - INFO : building image from target_files RECOVERY...
robotnix-lineage_dreamlte> 2023-05-05 17:38:05 - add_img_to_target_files.py - INFO :
| 17:54:32 |
matthewcroughan - nix.zone | seemed to happen in an earlier derivation too | 17:54:36 |
matthewcroughan - nix.zone | This seems to happen with or without my addition | 18:52:13 |
matthewcroughan - nix.zone | * This seems to happen with or without my addition of the gapps folder | 18:52:16 |
matthewcroughan - nix.zone | * This seems to happen with or without my addition of the vendor/gapps folder | 18:52:22 |
matthewcroughan - nix.zone | Total function call is like this | 18:52:36 |
matthewcroughan - nix.zone | { pkgs, ... }:
{
device = "dreamlte";
flavor = "lineageos";
androidVersion = 12;
buildDateTime = 1667856426;
microg.enable = true;
# Change variant for debugging purposes
# variant = "eng";
apps = {
fdroid.enable = true;
};
source.dirs."vendor/gapps".src = pkgs.fetchgit {
rev = "d547c376983cc644b5a6b4e7ed1fd59984f5569c";
url = "https://gitlab.com/MindTheGapps/vendor_gapps.git";
sha256 = "sha256-SkAsHteEcveqIjDnB55s4rTVefrOTlzIW1nTOGh0448=";
};
source.dirs."device/samsung/dreamlte".src = pkgs.fetchgit {
rev = "f885b96f68f7c9579134a316206e3a556a3f870a";
url = "https://github.com/8890q/android_device_samsung_dreamlte.git";
sha256 = "sha256-M1kEgnfI0xn1vVjeAKXii+CnQelpE/S4LaL63++em1g=";
};
source.dirs."device/samsung/universal8895-common".src = pkgs.fetchgit {
rev = "267d670aac1f6b02161d3ff164f411827e4ee68c";
url = "https://github.com/8890q/android_device_samsung_universal8895-common.git";
sha256 = "sha256-1AfV/EZBJXKYUOGodOqOF0MQhGynGpsy3ATyylKSuiM=";
};
source.dirs."kernel/samsung/universal8895".src = pkgs.fetchgit {
rev = "d45ecc236a98c10f28d7a0cad5238379634366af";
url = "https://github.com/8890q/android_kernel_samsung_universal8895.git";
sha256 = "sha256-fwkQ9aKjK34go+u9ldxUBfCYyXZUl9uFc2uq6h9NcTI=";
};
source.dirs."vendor/samsung".src = pkgs.fetchgit {
rev = "64dc02b8f0f12ca3abff2b2674a09c8e57559f7d";
url = "https://github.com/8890q/proprietary_vendor_samsung.git";
sha256 = "sha256-xmof6lFeD75amubfYiExgKAYq296LadGerI3Uu2fhLw=";
};
source.dirs."hardware/samsung".src = pkgs.fetchgit {
rev = "ee54c6737f5274e8af52de8c11544c97fdeef296";
url = "https://github.com/8890q/android_hardware_samsung.git";
sha256 = "sha256-XnHxAIi5/gDO5h+STAiiwdjltBh1nExmSEqcMLRhh58=";
};
source.dirs."device/samsung_slsi/sepolicy".src = pkgs.fetchgit {
rev = "a03fb392d93f42d99d3f43303954ac27949936d2";
url = "https://github.com/LineageOS/android_device_samsung_slsi_sepolicy.git";
sha256 = "sha256-ccpFjGb7f4alK6+cuTC91xqB8jRNZwX8OeZYz3Z0dng=";
};
}
| 18:53:27 |
silent_water | In reply to @matthewcroughan:defenestrate.it
Atemu:
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read SYSTEM/etc/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read VENDOR/etc/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read VENDOR/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read PRODUCT/etc/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read PRODUCT/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read SYSTEM_EXT/etc/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read SYSTEM_EXT/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read ODM/etc/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read ODM/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read VENDOR_DLKM/etc/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read VENDOR_DLKM/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read ODM_DLKM/etc/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Failed to read ODM_DLKM/build.prop
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Unable to get boot image build props: Failed to run command '['unpack_bootimg', '--boot_img', '/build/boot.img6r1N0V', '--out', '/build/boot_L78I4b.img']' (exit code 1):
dreamlte-ota_update> Traceback (most recent call last):
dreamlte-ota_update> File "/nix/store/mvnw94935qphb1z1bhv0a8vdbvaz3rmz-ota-tools/bin/unpack_bootimg/internal/stdlib/runpy.py", line 197, in _run_module_as_main
dreamlte-ota_update> File "/nix/store/mvnw94935qphb1z1bhv0a8vdbvaz3rmz-ota-tools/bin/unpack_bootimg/internal/stdlib/runpy.py", line 87, in _run_code
dreamlte-ota_update> File "/nix/store/mvnw94935qphb1z1bhv0a8vdbvaz3rmz-ota-tools/bin/unpack_bootimg/__main__.py", line 12, in <module>
dreamlte-ota_update> File "/nix/store/mvnw94935qphb1z1bhv0a8vdbvaz3rmz-ota-tools/bin/unpack_bootimg/internal/stdlib/runpy.py", line 197, in _run_module_as_main
dreamlte-ota_update> File "/nix/store/mvnw94935qphb1z1bhv0a8vdbvaz3rmz-ota-tools/bin/unpack_bootimg/internal/stdlib/runpy.py", line 87, in _run_code
dreamlte-ota_update> File "/nix/store/mvnw94935qphb1z1bhv0a8vdbvaz3rmz-ota-tools/bin/unpack_bootimg/unpack_bootimg.py", line 547, in <module>
dreamlte-ota_update> File "/nix/store/mvnw94935qphb1z1bhv0a8vdbvaz3rmz-ota-tools/bin/unpack_bootimg/unpack_bootimg.py", line 543, in main
dreamlte-ota_update> File "/nix/store/mvnw94935qphb1z1bhv0a8vdbvaz3rmz-ota-tools/bin/unpack_bootimg/unpack_bootimg.py", line 474, in unpack_image
dreamlte-ota_update> File "/nix/store/mvnw94935qphb1z1bhv0a8vdbvaz3rmz-ota-tools/bin/unpack_bootimg/unpack_bootimg.py", line 215, in unpack_boot_image
dreamlte-ota_update> UnicodeDecodeError: 'utf-8' codec can't decode byte 0xcc in position 532: invalid continuation byte
dreamlte-ota_update> 2023-05-05 17:38:56 - common.py - WARNING : Can't find META/ab_partitions.txt
dreamlte-ota_update> Compressing system.new.dat with brotli
I've seen this a lot. the archive is actually cpio format even though it has a .zip extension and it seems to refer to files by relative path. I have it working on this PR https://github.com/danielfullmer/robotnix/pull/203 by copying all the target files into the nix store https://github.com/danielfullmer/robotnix/pull/203/files#diff-01ce112b99217c9566778d6f18cba6e0d00dc9ef4990d7eb2c5c5ea9b1e348d5R437 and by periodically listing the contents of the archive like https://github.com/danielfullmer/robotnix/pull/203/files#diff-01ce112b99217c9566778d6f18cba6e0d00dc9ef4990d7eb2c5c5ea9b1e348d5R440 and https://github.com/danielfullmer/robotnix/pull/203/files#diff-c74b91c4e4fe9785051a9076651426dceb221001a30b1bb9359c608d66b8f0a1R63, which seems to force the files to get resolved before it's intermediate state gets cleaned up during the build. I can't fully explain the behavior, I just know this works reliably. | 20:55:18 |
matthewcroughan - nix.zone | In reply to @therivercass:matrix.org I've seen this a lot. the archive is actually cpio format even though it has a .zip extension and it seems to refer to files by relative path. I have it working on this PR https://github.com/danielfullmer/robotnix/pull/203 by copying all the target files into the nix store https://github.com/danielfullmer/robotnix/pull/203/files#diff-01ce112b99217c9566778d6f18cba6e0d00dc9ef4990d7eb2c5c5ea9b1e348d5R437 and by periodically listing the contents of the archive like https://github.com/danielfullmer/robotnix/pull/203/files#diff-01ce112b99217c9566778d6f18cba6e0d00dc9ef4990d7eb2c5c5ea9b1e348d5R440 and https://github.com/danielfullmer/robotnix/pull/203/files#diff-c74b91c4e4fe9785051a9076651426dceb221001a30b1bb9359c608d66b8f0a1R63, which seems to force the files to get resolved before it's intermediate state gets cleaned up during the build. I can't fully explain the behavior, I just know this works reliably. Does the error I posted actually have an impact on the result? | 20:56:39 |
matthewcroughan - nix.zone | the result is like a 700~ MiB ZIP, if I flash it is it going to work? | 20:57:05 |