| 2 Jan 2025 |
 atemu12 | That's not going to be an issue | 16:45:10 |
| atemu12 | Building meaningful checks is the harder problem | 16:45:47 |
 oak 🏳️🌈♥️ | I saw your PR about enabling LineageOS's prebuilt webview and it taking a lots of disk space | 17:02:07 |
| oak 🏳️🌈♥️ | Did you check is the LOS prebuilt webview a trichrome-variant of the Chromium build? | 17:02:32 |
| atemu12 | No but I solved that issue | 17:03:31 |
| oak 🏳️🌈♥️ | I think Trichrome is a build which has 3 APKs, one for Chromium, one for Webview, and one for shared common parts both of those use | 17:03:34 |
| atemu12 | The problem was caused by robotnix; more specifically what I declared it to do | 17:03:45 |
| atemu12 | LOS doesn't need a chromium because it has this webview browser | 17:04:03 |
| atemu12 | And honestly anyone who wants a chromium for browsing purposes should install one at runtime | 17:04:20 |
| oak 🏳️🌈♥️ | (In addition to Trichrome, you can just build either standalone Chromium or standalone Webview, but that then takes more disk space) | 17:05:48 |
| oak 🏳️🌈♥️ | * (In addition to Trichrome, you can just build either standalone Chromium or standalone Webview, or both separately as standalone, but that then takes more disk space) | 17:06:00 |
| atemu12 | It claims to be a "webview" apk | 17:06:16 |
| oak 🏳️🌈♥️ | but yeah, about the CI and testing, I think proper testing would actually be to install the build into some device, and try to run some tests with that | 17:08:54 |
| atemu12 | Emulator would be ideal | 17:09:25 |
| oak 🏳️🌈♥️ | but even checking that stuff builds successfully is usually a good start | 17:09:25 |
| atemu12 | Yes although, at this point, if I can't verify that something works as intended or the author convinced me that they have done so sufficiently, I'm not merging it anyways | 17:10:47 |
| atemu12 | CI would be most useful for catching stupid careless mistakes | 17:11:17 |
| atemu12 | Or enforcing standards | 17:11:31 |
| oak 🏳️🌈♥️ | It's also useful for finding regressions, for example if you change something on LineageOS 21 builds, something might break on LOS 20 or AOSP build | 17:12:19 |
| oak 🏳️🌈♥️ | Currently the situation is a bit messy, we have documentation which claims all kinds of features, which don't currently work, but it's not stated anywhere which things work and which don't. And things that aren't actively tested on CI will get bit rot | 17:13:03 |
| oak 🏳️🌈♥️ | Actually there is Status list and I don't completely agree on stuff on subject to removal -column :D The OTA updater does work and I do use it | 17:17:23 |
| oak 🏳️🌈♥️ | It's not that useful though, because after running OTA update I still need to manually reinstall Magisk and MindTheGapps through Recovery | 17:18:03 |
| oak 🏳️🌈♥️ | I don't know could I already bake Magisk and MindTheGApps into the build | 17:18:26 |
| atemu12 | Fair point | 17:19:20 |
| atemu12 | Please send a PR :) | 17:19:30 |
| atemu12 | I don't know about Google's spyware but Magisk: Yes | 17:20:08 |
| atemu12 | https://github.com/nix-community/robotnix/pull/266 | 17:20:23 |
| atemu12 | https://github.com/nix-community/robotnix/issues/14 | 17:20:33 |
| atemu12 | (I think you'd know more about embedding gapps into AOSP than I do given you've worked in the industry :) ) | 17:22:09 |
| oak 🏳️🌈♥️ | Yeah they did it in one project in the past but I don't have access to the project's Android tree anymore so I could check how it was done | 17:22:54 |
