| 16 Nov 2024 |
atemu12 | 11e02c0ce2452b3822a2f8695ac600b6e245ac9a | 02:34:00 |
oak 🏳️🌈♥️ | Am I seeing correctly that this commit actually adds a patch and fix for the issue, but it's not used anywhere | 02:37:43 |
atemu12 | I think I messed up the rebase back then | 02:38:00 |
atemu12 | It's used but only on 13 | 02:38:04 |
atemu12 | I thought it was new for 20 | 02:38:23 |
oak 🏳️🌈♥️ | Okay, so now I can try to go back to the master version, try to do the update.sh again, and add the patch | 02:38:36 |
atemu12 | So port the patch and adjust the guard | 02:38:41 |
atemu12 | You should only need the patch | 02:38:56 |
atemu12 | Does it build now? | 03:05:14 |
oak 🏳️🌈♥️ | I'm just testing, I see the patch got included | 03:15:52 |
oak 🏳️🌈♥️ | It's fun how in the end all this gets fixed by decrementing one number in one source code file :D | 03:18:27 |
oak 🏳️🌈♥️ | I checked from lineage-18.1 and there they had rejected the gerrit patch, but I can make PR about this | 03:18:57 |
atemu12 | Sure | 03:19:07 |
oak 🏳️🌈♥️ | Thanks for all the help | 03:21:15 |
atemu12 | No problem | 03:21:27 |
oak 🏳️🌈♥️ | Let's see if the next fight is about getting the version 20 to build | 03:21:30 |
atemu12 | If 20 didn't build that'd be news to me and my device running 20 ;) | 03:21:49 |
oak 🏳️🌈♥️ | Ah for the PR I would actually need to update the repo.json also to make the problem appear, otherwise it will fail to apply the patch | 03:25:34 |
atemu12 | Feel free to bump LOS 19 | 03:25:59 |
atemu12 | (Separate commit though please.) | 03:26:33 |
oak 🏳️🌈♥️ | I hope this transition to LineageOS 20 goes well | 03:40:31 |
atemu12 | Those who have tested backups don't need hope ;) | 03:40:53 |
oak 🏳️🌈♥️ | Many times during these past few years I've had thoughts I will just give up with this stuff and buy an iPhone | 03:40:54 |
atemu12 | Haha :D | 03:41:02 |
oak 🏳️🌈♥️ | What's the good way for doing backups of applications nowadays? Back in the days I even bought the Pro Version of Titanium Backup but that hasn't been updated for new Android versions anymore | 03:43:59 |
atemu12 | Nothing | 03:44:13 |
atemu12 | Android backups suck arse | 03:44:17 |
atemu12 | But, uhh, I've written something to cope with that but it's quite something | 03:44:37 |
atemu12 | https://github.com/Atemu/Polardroid | 03:44:43 |
oak 🏳️🌈♥️ | buildPhase completed in 40 minutes 59 seconds | 03:56:55 |