| 1 Apr 2024 |
 eyJhb | Atemu: any reason for omitting -u/ | 11:54:23 |
| eyJhb | * Atemu: any reason for omitting -u? | 11:54:24 |
 atemu12 | eyJhb: -u? | 12:01:15 |
| eyJhb | unset variables | 12:01:40 |
| eyJhb | https://github.com/nix-community/robotnix/pull/230#issuecomment-2028476496 I can't copy the link to the review I started, but I wanted to have -u added to the set in the PR :D | 12:02:09 |
| atemu12 | None | 12:02:36 |
| atemu12 | Though I didn't write that code ;) | 12:02:47 |
| eyJhb | Would it be welcome with a new PR that adds -u? :D | 12:03:15 |
| atemu12 | I wouldn't oppose it I guess but I don't think that's ever bitten us | 12:05:09 |
| eyJhb | https://github.com/nix-community/robotnix/pull/232 made a PR for it | 12:07:38 |
| eyJhb | I'm not sure if it has, or hasn't. I had a case while bumping, where it actually errored out because of a unset variable :) | 12:08:14 |
| eyJhb | (still finished building, but did not seem ideal) | 12:08:23 |
| eyJhb | Mostly wanted it added, so that it would fit what setup in nixpkgs does. Would make sense to expect the same behaviour | 12:08:50 |
| atemu12 | Sure then | 12:09:30 |
| atemu12 | Did you build this? | 12:09:39 |
| eyJhb | I've built it once before, but I'll validate it once more just to be sure. :) Doesn't hurt anyone double checking that it works :D | 12:10:17 |
| eyJhb | Atemu: Removed one of the -u, but kept it in the place I originally wanted. | 12:20:51 |
| eyJhb | Seems to work fine, currently building, no errors :) I can report back once it's done. | 12:21:04 |
 CyberShadow | Is the unset variable in our code? If so then it may make sense to keep -u and be explicit about the variable being optional e.g. with ${var-} | 12:59:04 |
| eyJhb | In reply to @cybershadow:cy.md
Is the unset variable in our code? If so then it may make sense to keep -u and be explicit about the variable being optional e.g. with ${var-} I don't think it was robotnix code that caused it, but I think it's great to have included. Because we shouldn't be doing that anyways. Can be removed if it becomes troublesome | 14:24:14 |
| eyJhb | In reply to @eyjhb:eyjhb.dk
https://github.com/nix-community/robotnix/pull/232 made a PR for it Finished my built without any issues :) | 14:43:01 |
| eyJhb | Damn it. I tried to build bacon (oneplus one), using robotnix. But I can't do that, since it's on 18.1.. :D And I get this device/oppo/common/common.mk:29: error: _nic.PRODUCTS.[[device/oneplus/bacon/lineage_bacon.mk]]: "vendor/oppo/msm8974-common/msm8974-common-vendor.mk" does not exist. | 16:08:12 |
|  budric joined the room. | 16:12:54 |
| atemu12 | Bacon needs a hack | 17:23:44 |
| atemu12 | This may have broken at some point | 17:23:56 |
| 2 Apr 2024 |
| eyJhb | I don't see any specific mentions of bacon in the source | 07:57:21 |
| eyJhb | Trying to get the emulator to work now on master. Would be nice if that could just be used for testing. However, not sure how useful. | 08:18:56 |
| eyJhb | The kernel building code is... not fun to say the least. | 09:25:30 |
| atemu12 | Emulator hs been broken for a while | 09:34:31 |
| atemu12 | Likely just needs an update? | 09:35:00 |
