!UUYziobKGGxpovWyAN:nixos.org

Robotnix

240 Members
Build Android (AOSP) using Nix | https://github.com/danielfullmer/robotnix74 Servers

Load older messages


SenderMessageTime
23 Dec 2024
@oak:universumi.fioak 🏳️‍🌈♥️Yeah, I think we could have both, IIRC there's already a mechanism which you can optionally use to select one of the webviews. I don't think adding prebuilt webview should anyway be that big task18:54:08
@atemu12:matrix.orgatemu12Yup, just needs to be done18:54:50
@oak:universumi.fioak 🏳️‍🌈♥️Maybe I could also have a look on adding that, but I don't have my second test phone with me now during christmast time18:54:53
@atemu12:matrix.orgatemu12We should really get the emulator to work again too18:55:18
@oak:universumi.fioak 🏳️‍🌈♥️How does it work if you build LineageOS "normally" (I mean without Robotnix)? Does it have the prebuilt webview already added in repo manifest?18:55:45
@atemu12:matrix.orgatemu12It does but I think robotnix was interacting with it poorly 18:56:07
@atemu12:matrix.orgatemu12It'd always be disabled IIRC18:56:15
@atemu12:matrix.orgatemu12So you had to use the robotnix-provided webview18:56:28
@atemu12:matrix.orgatemu12Or none at all18:56:32
@atemu12:matrix.orgatemu12I'm also not sure the LOS webview is up to date18:56:46
@oak:universumi.fioak 🏳️‍🌈♥️Yeah actually now I recall, when I was updating those flavour repo.json files, I noticed it does fetch prebuilt webview, and I had some problems with it. (To fix the problems I had to remove the repo.json and do completely clean run of the update script.)18:57:44
@oak:universumi.fioak 🏳️‍🌈♥️The problem is that if you build without any webview at all, if you want to use GApps, you can't log into your google account if you don't have at least some kind of webview18:59:00
@oak:universumi.fioak 🏳️‍🌈♥️I was wondering why does it have to fetch the prebuilt webview if it's not going to be used anyway, but I guess the reason is that it's in the LineageOS's repo manifest19:00:33
@oak:universumi.fioak 🏳️‍🌈♥️https://github.com/LineageOS/android_external_chromium-webview_prebuilt_arm64 Well it's not that old19:04:24
@oak:universumi.fioak 🏳️‍🌈♥️I'm curious what was the build issue though19:04:38
@oak:universumi.fioak 🏳️‍🌈♥️https://android.googlesource.com/platform/external/chromium-webview/ This should be the place for official releases of webview from Chromium project, with these Google projects I always wonder what is the correct branch to use though, maybe main?19:12:48
@atemu12:matrix.orgatemu12https://divestos.org/pages/news#end22:11:08
@atemu12:matrix.orgatemu12Well darn, so much for using Mulch...22:11:21
@magic_rb:matrix.redalder.orgmagic_rb Huh that was abrupt holy shit 22:22:49
24 Dec 2024
@oak:universumi.fioak 🏳️‍🌈♥️I wonder what are the important things to take into account when packaging those prebuilt apks. Mainly first question that comes to mind is that do the signatures need to be changed or spoofed?22:17:24
@oak:universumi.fioak 🏳️‍🌈♥️* I wonder what are the important things to take into account when packaging those prebuilt apks. Mainly first question that comes to mind is do the signatures need to be changed or spoofed?22:17:39
@atemu12:matrix.orgatemu12Depends on whether you want to sign them with your key or keep the upstream key22:18:00
@atemu12:matrix.orgatemu12There's valid reasons for both22:18:42
@atemu12:matrix.orgatemu12You'd want to sign it with your key unless you want to be able to update it independently of the ROM22:19:23
@atemu12:matrix.orgatemu12(Without signing it yourself with your own key again.)22:19:36
@oak:universumi.fioak 🏳️‍🌈♥️https://github.com/nix-community/robotnix/blob/master/modules/apps/chromium.nix#L127-L130 I'm just looking at this22:21:12
@oak:universumi.fioak 🏳️‍🌈♥️If you don't provide a signing key, then it is changed to some "snake oil" key22:21:26
@atemu12:matrix.orgatemu12My understanding is that this snake oil signature is later replaced with the actual signature22:22:00
@atemu12:matrix.orgatemu12But, again, I never used signing22:22:10
@countoren:matrix.orgcountoren

Hi,
I was looking at your response and back to my code
I do have the latest commit ```
ddefce63fe8ec896c24325e1680959a893a581ff

with this flake

{
description = "Robotnix configuration for OnePlus 8 Pro";

inputs.robotnix.url = "github:danielfullmer/robotnix";

outputs = { self, robotnix }: {
robotnixConfigurations."oneplus8pro" = robotnix.lib.robotnixSystem ({ config, pkgs, ... }: {
# Required options
device = "instantnoodlep"; # Codename for OnePlus 8 Pro
flavor = "lineage-20.0"; # Change this to 'lineageos' if you want LineageOS, otherwise keep 'grapheneos' if supported

  # Optional configurations
  # buildDateTime = 1584398664; # Update if you want to push OTA updates for your custom changes

  # If you have keys for signing, enable this
  # signing.enable = true;
  # signing.keyStorePath = "/var/secrets/android-keys";
  # Enable ccache if you want faster subsequent builds
  # ccache.enable = true;
  apps.chromium.enable = false;
});

# Default package for building the image
defaultPackage.x86_64-linux = self.robotnixConfigurations."oneplus8pro".img;

};
}

getting back 

error: builder for '/nix/store/jgw8vkv0rg819c3m9d1a9dwl25xwfdnk-build=make-patched.drv' failed with exit code 1;
last 25 log lines:
> Perhaps you used the wrong -p or --strip option?
> The text leading up to this was:
> --------------------------
> |diff --git a/core/definitions.mk b/core/definitions.mk
> |index c5fe76b606..5c8f85b4a4 100644
> |--- a/core/definitions.mk
> |+++ b/core/definitions.mk
> --------------------------
> File to patch:
> Skip this patch? [y]
> Skipping patch.
> 4 out of 4 hunks ignored
> can't find file to patch at input line 100
> Perhaps you used the wrong -p or --strip option?
> The text leading up to this was:
> --------------------------
> |diff --git a/tools/libhost/CopyFile.c b/tools/libhost/CopyFile.c
> |index f9bda86fd1..44b36e4bdf 100644
> |--- a/tools/libhost/CopyFile.c
> |+++ b/tools/libhost/CopyFile.c
> --------------------------
> File to patch:
> Skip this patch? [y]
> Skipping patch.
> 1 out of 1 hunk ignored
For full logs, run 'nix log /nix/store/jgw8vkv0rg819c3m9d1a9dwl25xwfdnk-build=make-patched.drv'.

22:26:12

Show newer messages


Back to Room ListRoom Version: 6