| 1 Apr 2024 |
 eyJhb | https://github.com/nix-community/robotnix/pull/230#issuecomment-2028476496 I can't copy the link to the review I started, but I wanted to have -u added to the set in the PR :D | 12:02:09 |
 atemu12 | None | 12:02:36 |
| atemu12 | Though I didn't write that code ;) | 12:02:47 |
| eyJhb | Would it be welcome with a new PR that adds -u? :D | 12:03:15 |
| atemu12 | I wouldn't oppose it I guess but I don't think that's ever bitten us | 12:05:09 |
| eyJhb | https://github.com/nix-community/robotnix/pull/232 made a PR for it | 12:07:38 |
| eyJhb | I'm not sure if it has, or hasn't. I had a case while bumping, where it actually errored out because of a unset variable :) | 12:08:14 |
| eyJhb | (still finished building, but did not seem ideal) | 12:08:23 |
| eyJhb | Mostly wanted it added, so that it would fit what setup in nixpkgs does. Would make sense to expect the same behaviour | 12:08:50 |
| atemu12 | Sure then | 12:09:30 |
| atemu12 | Did you build this? | 12:09:39 |
| eyJhb | I've built it once before, but I'll validate it once more just to be sure. :) Doesn't hurt anyone double checking that it works :D | 12:10:17 |
