| 7 Sep 2021 |
 kranzes | https://github.com/ForkLineageOS/android_frameworks_base/commit/ee9742b6728f0ecb089d8783c0b8bee17debacfa#diff-533c45df53f4235f81d5ded58da796ab9f55f21cb0939077cae48f48c961188b | 23:54:14 |
| kranzes | some of these changes are redundant when using microg.enable | 23:54:24 |
| kranzes | since the microg already applies some of these changes | 23:54:37 |
| kranzes | 
Download image.png | 23:54:45 |
| kranzes | there are two options for me, one to use git revert to revert that commit | 23:55:05 |
| kranzes | * there are three options for me, one to use git revert to revert that commit | 23:55:14 |
 danielrf | Does forklineageos already provide the MicroG apk as well as the patch? | 23:55:22 |
| kranzes | second, remove some of the patches that microg through robotnix does | 23:55:41 |
| kranzes | third to patch frameworks_base from forklineageos through robotnix | 23:56:09 |
| kranzes | In reply to @danielrf:matrix.org
Does forklineageos already provide the MicroG apk as well as the patch? no | 23:56:11 |
| kranzes | it just has that spoofing thing | 23:56:11 |
| kranzes | what i used to do is fork forklineageos's base frameworks | 23:56:53 |
| kranzes | then run git revert on it | 23:57:00 |
| kranzes | but thats a bit of a hass;e | 23:57:03 |
| kranzes | * but thats a bit of a hassle | 23:57:04 |
| kranzes | In reply to @kranzes:matrix.org
third to patch frameworks_base from forklineageos through robotnix this i think maybe makes the most sense | 23:57:48 |
| kranzes | but i dont know how to write patches | 23:57:53 |
| danielrf | Do you know about the revert option in pkgs.fetchpatch? | 23:58:29 |
| kranzes | no | 23:58:37 |
| kranzes | 🤔 | 23:58:56 |
| danielrf | Well it does what it sounds like. I sometimes use it to revert commits that upstream provides that we don't want | 23:59:15 |
| kranzes | In reply to @danielrf:matrix.org
Well it does what it sounds like. I sometimes use it to revert commits that upstream provides that we don't want that is exactly what i am looking for | 23:59:30 |
| kranzes | could you show me how to use it in the flake.nix? | 23:59:36 |
| danielrf | e.g. https://github.com/danielfullmer/robotnix/blob/d9018fbaed2eadf81b85b6dd075a4994230e3b97/flavors/lineageos/default.nix#L105 | 23:59:42 |
| 8 Sep 2021 |
| danielrf | it would be something like: source.dirs."frameworks/base".patches = lib.mkBefore [ (pkgs.fetchPatch ....) ]; | 00:00:29 |
| kranzes | what is that .patch file exactly | 00:00:43 |
| kranzes | * what is that .patch file exactly? | 00:00:50 |
| kranzes | also why do we need mkBefore there? | 00:01:15 |
| danielrf | This URL: https://github.com/ForkLineageOS/android_frameworks_base/commit/ee9742b6728f0ecb089d8783c0b8bee17debacfa.patch | 00:01:21 |
| kranzes | Oh i didnt know git has that | 00:01:38 |
