28 Mar 2024 |
hexa | * hm, what does it do? copy with permissions in tact? | 17:21:32 |
hexa | or does it try to create metadata in the nix store? | 17:22:09 |
hexa | * or does it try to create stuff in the nix store? | 17:22:19 |
adamcstephens | https://github.com/lxc/incus/blob/ce15a0a8c41d96466ff6222f8c2d52051fcfba85/internal/util/filesystem.go#L92 | 17:25:30 |
adamcstephens | the former | 17:25:34 |
adamcstephens | * closer to the former | 17:25:49 |
adamcstephens | https://github.com/lxc/incus/blob/ce15a0a8c41d96466ff6222f8c2d52051fcfba85/cmd/incus-simplestreams/main_add.go#L348 | 17:26:40 |
hexa | that code is so very much go | 17:29:34 |
hexa | to copy a file, open two file descriptors, and then copy between them | 17:29:49 |
adamcstephens | indeed. the idiom is to make do with the standard library, which is spartan. | 17:30:23 |
adamcstephens | and 3x the lines for every error check | 17:30:42 |
adamcstephens | on the plus side, properly passed errors are easy to trace :) | 17:32:15 |
hexa | so, I'm a bit surprised that you call os.Create(dest) and then don't own the resulting file | 17:32:42 |
hexa | becausing chowning to foreign uid is only possible as root iirc | 17:33:03 |
adamcstephens | i wouldn't have called this one properly passed, since no context was added to where it came from | 17:33:04 |
adamcstephens | this filesystem util is probably mostly used by the server | 17:33:28 |
adamcstephens | ideally i don't want it to copy the file at all | 17:33:44 |
adamcstephens | even just trying to generate-metadata wants a write handle on the file | 17:35:04 |
hexa | sus | 17:35:22 |
adamcstephens | oh | 17:35:43 |
adamcstephens | because this is just a wizard to manually create a metadata tarball | 17:36:02 |
adamcstephens | this whole thing is still sus | 17:37:36 |
adamcstephens | is there a consumable list of channel bumps ? | 17:43:33 |
hexa | push events to the relevant branches on github? | 17:44:27 |
hexa | god I wish we had something sensibel 😄 | 17:44:36 |
hexa | * god I wish we had something sensible 😄 | 17:44:43 |
adamcstephens | right? like an api i could consume? :) | 17:44:53 |
hexa | the whole release pipeline is such utter legacy garbage that gives you braindamage | 17:45:41 |
hexa | * the whole release pipeline is such utter legacy garbage that gives you brain damage | 17:45:50 |
| [0x4A6F] joined the room. | 19:40:07 |