20 Mar 2024 |
adamcstephens | or silently passed through | 01:21:58 |
hexa | yeah, the manual is markdown, that's all I know | 01:22:05 |
hexa | and for some reason that includes the options | 01:22:21 |
hexa | I had no idea you could pass a list to mkPackageOption | 01:24:39 |
adamcstephens | yeah, someone else did that before me. mkg maybe | 01:26:27 |
hexa | the negation in the firewall assertion 🙈 | 01:26:48 |
adamcstephens | yeah that's some ugly logic. but... feel free to give me an equivalent alternative :) | 01:28:11 |
hexa | no 😄 | 01:28:25 |
adamcstephens | only idea i have is to pull the inner condition out to a variable, but it's just shifting the code around | 01:29:05 |
hexa | yeah, don't bother | 01:29:32 |
hexa | lib.optional should not exis | 01:31:27 |
hexa | * lib.optional should not exist | 01:31:29 |
adamcstephens | because it's not clearly a list? | 01:32:27 |
hexa | I remember that I confused optionals and optional very often early on | 01:33:44 |
hexa | but now I think just optionals should be sufficient for everything | 01:33:58 |
adamcstephens | ok, works for me :) | 01:34:22 |
hexa | making the argument a proper list makes extending it much simpler | 01:34:56 |
adamcstephens | yep | 01:35:03 |
hexa | also the reason I'm a friend of always expanding lists cough | 01:35:09 |
hexa | but that ship has sailed | 01:35:12 |
adamcstephens | what do you mean always expanding lists? | 01:35:37 |
hexa | to one line per item | 01:35:47 |
adamcstephens | ahh | 01:36:05 |
adamcstephens | we get that, after we get two items | 01:36:31 |
adamcstephens | i feel like the ovs line should split anyway given its lenght | 01:41:21 |
adamcstephens | 101 characters | 01:41:47 |
hexa | yeah, but that it flips around between one and two item 🤷 | 01:41:57 |
adamcstephens | yeah extra diff churn | 01:42:12 |
hexa | I know the discussion is probably not that simple | 01:42:20 |
adamcstephens | probably not | 02:14:44 |