18 Mar 2024 |
adamcstephens | i've not used filterForward myself | 14:29:36 |
adamcstephens | i'd honestly rather not get too tricky with this. i think the goals should be a working out of box experience for those who are taking a simple/default setup, without making assumptions that will affect those who have more complex/advanced needs. | 14:32:30 |
adamcstephens | or we just solve this with documentation | 14:34:10 |
adamcstephens | if you want to pursue some automation with hooks, i'd recommend reaching out to stgraber though irc/github/discourse and see what his thoughts are | 14:39:58 |
mkg20001 | ok, will do | 14:41:37 |
19 Mar 2024 |
| NixOS Moderation Botchanged room power levels. | 00:29:52 |
adamcstephens | 🤞i can finally move this PR forward | 02:30:11 |
adamcstephens | took some digging to fix this test which was already failing. because you know we can't mark failed builds as failed 😿 | 02:30:52 |
adamcstephens | https://github.com/NixOS/nixpkgs/pull/294548 | 03:30:22 |
hexa | lib.mdDoc is obsolete | 23:38:05 |
20 Mar 2024 |
adamcstephens | I added none. Are there plans for a bulk cleanup? | 00:46:11 |
hexa | also … sometimes using with should be ok 😄 | 00:49:32 |
hexa | Download image.png | 00:49:34 |
adamcstephens | Pkgs is so short :) I prefer to be explicit myself but understand others prefer with in this case. I’d say it’s ok but not my preference | 01:05:33 |
adamcstephens | Lots of dependencies for this package | 01:08:45 |
adamcstephens | If you insist I’ll use with ;) | 01:08:56 |
hexa | how could I? | 01:09:39 |
hexa | I think it's silly to complain about every with that we have in nixpkgs | 01:10:07 |
hexa | it started at toplevel with lib and now they're coming for meta =with lib; | 01:10:30 |
hexa | * it started at toplevel with lib and now they're coming for meta = with lib; | 01:10:57 |
adamcstephens | I just tend not to use them out of preference. I don’t really like a global with lib, but smaller scopes seem fine to me | 01:11:52 |
adamcstephens | I’m definitely not trying to convince others | 01:12:10 |
hexa | I tend to inherit from lib | 01:12:29 |
adamcstephens | Yeah that’s better for sure | 01:12:44 |
hexa | and with lists like the one above I generally don't like to repeat myself | 01:12:52 |
adamcstephens | I like that I can read every line and know where it came from. If there were some other variables in the `let` included in this list, it could be less clear using `with` what the source was. | 01:15:15 |
adamcstephens | I do agree this list is probably past the length most people would side with me | 01:15:58 |
adamcstephens | Any other thoughts? I’ll update that and the mddoc | 01:16:43 |
hexa | I saw both on mobile, hence commented here | 01:17:36 |
hexa | let me check | 01:17:38 |