| 5 Feb 2024 |
 hexa | open PR, post to discourse | 14:19:08 |
| hexa | ask in this room 🤡 | 14:19:15 |
 adamcstephens | :) | 14:19:19 |
| hexa | give it a month or so | 14:19:23 |
| hexa | send it | 14:19:26 |
| hexa | unstable breaking changes thread comes to mind | 14:19:35 |
| adamcstephens | ok, you motivated me. i'll move that higher on my list of projects | 14:20:54 |
| hexa | https://discourse.nixos.org/t/breaking-changes-announcement-for-unstable/17574 | 14:24:28 |
| adamcstephens | ye[ | 14:29:24 |
| adamcstephens | * yep | 14:29:26 |
| adamcstephens | https://github.com/AshleyYakeley/NixVirt | 14:35:33 |
| adamcstephens | declarative resources is really the last major thing i think we need for incus | 14:35:45 |
| 8 Feb 2024 |
 aanderse | so there's no way for me to conditionally say a machine is an lxc container where the condition is based on `config`, right?
in other words... you *must* `imports` the lxc functionality which has the usual infinite recursion implications? | 01:16:21 |
| adamcstephens | Meaning you can’t conditionally import the profile, yes | 01:20:28 |
| adamcstephens | I normally just `imports = [ (modulesPath + "/virtualisation/lxc-container.nix") ];` on the host | 01:21:47 |
| aanderse | i thought so... hmmm | 01:22:33 |
| adamcstephens | It may be possible to turn this into a regularly imported nixos module. I’ve never investigated doing so though  | 01:23:16 |
| aanderse | that wouldn't be trivial unfortunately... because lxc-container.nix imports things too | 01:24:03 |
| adamcstephens | It looks like a handful of the virtualization modules are | 01:24:06 |
| aanderse | 🤔 | 01:24:14 |
| aanderse | but i *really* want to mark a container using `config`
hmmm | 01:24:41 |
| adamcstephens | We could duplicate the common config into the container/vm modules. It’s not that extensive   | 01:25:23 |
| aanderse | yeah?
i would really love that | 01:26:05 |
| aanderse | I'm not sure what the precedent for module vs import is
anyone know? | 01:27:17 |
| aanderse | I'm trying to think of more examples of module vs import | 01:28:29 |
| aanderse | i can't at the moment, though I'm sure there are a number | 01:28:44 |
| adamcstephens | I’m not sure what the impact to releases is. mkg20001initially created the lxc-container file it seems :) | 01:29:09 |
| aanderse | ah
they would have something useful to say I'm sure
ping mkg20001 ... whenever you have a chance to comment i would greatly appreciate it, specifically why lxc-container.nix is a file to be imported rather than a nixos module | 01:30:57 |
 mkg20001 | the import idea came from qemu doing something similar | 01:33:35 |
| mkg20001 | there's no real reason why it's not just virtualisation.lxc.container-guest.enable = true; or similar | 01:33:57 |
