| 1 Jul 2025 |
 msgilligan | * Ok, I have a draft PR for zulu24 24.0.1: https://github.com/NixOS/nixpkgs/pull/421362
I've done really basic testing of Java builds on x86_64-linux, aarch64-linux, and aarch64-darwin.
| 00:20:18 |
| msgilligan | * Ok, I have a ~~draft~~ PR for zulu24 24.0.1: https://github.com/NixOS/nixpkgs/pull/421362
I've done really basic testing of Java builds on x86_64-linux, aarch64-linux, and aarch64-darwin.
| 17:07:03 |
| msgilligan | I marked it as non-draft, since it is "final" and ready-to-merge. | 17:07:38 |
| msgilligan | * Ok, I have a draft PR for zulu24 24.0.1: https://github.com/NixOS/nixpkgs/pull/421362
I've done really basic testing of Java builds on x86_64-linux, aarch64-linux, and aarch64-darwin.
| 17:07:57 |
| msgilligan | More testing would be nice, of course. Someone should try x86_64-darwin. | 17:15:25 |
 Tomodachi94 (they/them) | OpenJDK is, as far as I know | 21:26:36 |
| 2 Jul 2025 |
| msgilligan | What is the situation for automatic testing of JDKs on Nix? I've been looking through the documentation here and the source code of the various packages and it has been a slow learning process.
It would be nice if there was some general documentation on the various JDK packages in Nixpkgs as well as documentation specifically on contributing to the JDK modules such as how to run updaters (where they exist), how to run tests, how to add tests, etc.
Does anything like that exist? If not, where should it go so I can make an attempt to start one or more documents?
| 02:06:28 |
| msgilligan | Also is this the right/best place to ask questions like this? | 02:08:22 |
| msgilligan | * Also is this the right/best place to ask questions like this? (maybe I should ask on Discourse or somewhere else?) | 02:09:04 |
| msgilligan | I would think there should at least be some discussion of installing a JDK in the Languages and frameworks section of the Nixpkgs Reference Manual similar to what there is for other languages like, for example, Rust and Swift. | 03:23:11 |
| msgilligan | But that isn't the right place to talk about testing JDK updates. | 03:23:49 |
| msgilligan | I wrote a script (in Java!) to pull down the Zulu versions and hashes for updating a specified JDK version, but it’s not quite an auto-updater yet | 04:31:27 |
 Infinidoge 🏳️⚧️ | In reply to @msgilligan:matrix.org
What is the situation for automatic testing of JDKs on Nix? I've been looking through the documentation here and the source code of the various packages and it has been a slow learning process.
It would be nice if there was some general documentation on the various JDK packages in Nixpkgs as well as documentation specifically on contributing to the JDK modules such as how to run updaters (where they exist), how to run tests, how to add tests, etc.
Does anything like that exist? If not, where should it go so I can make an attempt to start one or more documents?
I haven't thought about it until now, but it's surprising that there doesn't seem to be any tests for the JDK in particular outside of generic builds/doesn't build | 04:38:28 |
| msgilligan | There are some really basic tests in correct to | 04:41:01 |
| msgilligan | * There are some really basic tests in corretto | 04:41:11 |
| Infinidoge 🏳️⚧️ | Oh huh, so there are, those should be ported to all of the other JDKs as a sanity check | 04:42:26 |
| msgilligan | Yeah, I was thinking it would make sense to have one set of tests that can run against all the different JDKs | 04:43:50 |
| Infinidoge 🏳️⚧️ | Something in pkgs/test at least | 04:44:09 |
| msgilligan | I made this draft PR earlier today: https://github.com/NixOS/nixpkgs/pull/421637 | 04:52:23 |
| Infinidoge 🏳️⚧️ | Put a review. installCheckPhase vs passthru tests I'm not entirely sure, but I think things like checking version should be installCheckPhase, and checking compilation should be passthru tests. | 05:07:24 |
| Infinidoge 🏳️⚧️ | (Above and beyond the checkPhase they should probably already have) | 05:07:48 |
| msgilligan | Yeah, I started writing that before I even knew about passthru. All the different options for tests are pretty confusing for a beginner. | 05:26:41 |
| Infinidoge 🏳️⚧️ | Nix in a nutshell, really | 05:27:02 |
| msgilligan | Well, it’s always easier to add a test when there are existing tests to add to. But I do think a paragraph or two about where the tests are or will/should be a would be helpful | 05:32:09 |
| msgilligan | Maybe someday we can run this:
https://adoptium.net/aqavit/ | 06:28:16 |
| msgilligan | I just realized this suggestion is wrong. The Languages and frameworks section is under Build Helpers and there is no JDK Build Helper. | 14:29:20 |
| 3 Jul 2025 |
| msgilligan | I'm getting schooled by @dtomvan (and GitHub checks) on testing on (above) PR #421637 😁 | 00:05:28 |
| 4 Jul 2025 |
| msgilligan | Merged: https://github.com/NixOS/nixpkgs/pull/421637 | 15:29:28 |
| msgilligan | * Merged: https://github.com/NixOS/nixpkgs/pull/421637
Thanks everyone for their help! | 15:30:40 |
| msgilligan | and I rebased https://github.com/NixOS/nixpkgs/pull/421362 so it will now get (minimally) tested. | 16:00:56 |
