7 Oct 2024 |
emily | it needs clean-up to not have a bunch of hardcoded stuff, but I'll put a PR up after that | 00:49:48 |
emily | I won't do any further refactoring right now, since I think it's best to have a zero-rebuild PR that encodes the exact ways in which the version-specific logic is messed up and then work from that | 00:50:08 |
Infinidoge 🏳️⚧️ | That variance is why I didn't attempt to clean up the files myself, I just didn't have the time to sit and work through it lol | 00:50:15 |
Infinidoge 🏳️⚧️ | Yeah, that's for the best | 00:50:21 |
emily | what I did was start with 23.nix , and then diff 21.nix → 23.nix (after running both through nixfmt to account for formatting differences). everything that changed is something that needs a conditional | 00:50:50 |
emily | then I just repeated that with 17.nix → 21.nix , etc. | 00:50:57 |
emily | JDK 8 was the worst, since a bunch of things are just different from every subsequent version. | 00:51:13 |
emily | after that I may nerd-snipe myself into clean-up → Darwin support → looking into getting rid of one of the two ~identical binary OpenJDK distributions | 00:52:12 |
emily | I'm referring to the Temurin build scripts a lot while working on this. I'm wondering if we shouldn't consider simply using them to build OpenJDK if possible. | 14:56:59 |
emily | they handle a lot of the tangled per-version logic for us and probably have settings that more reliably make sense. | 14:57:19 |
emily | they also already have Darwin support. | 14:58:24 |
emily | turns out that OpenJFK and OpenJFX 11 support cycles aren't aligned and I missed a >year-old WebKit 🫠 https://github.com/NixOS/nixpkgs/pull/347149 | 18:54:11 |
emily | oh god I found another JDK we ship Oracle's how many of them can there possibly be???? | 22:03:58 |
Infinidoge 🏳️⚧️ | Careful, if you talk about it too loudly it might undergo mitosis | 23:33:22 |
17 Oct 2024 |
| bendlas changed their profile picture. | 17:38:29 |
18 Oct 2024 |
emily | almost done with my OpenJDK/OpenJFX deduplication PR | 16:47:06 |
emily | after several long yak shaves | 16:47:11 |
emily | still need to do a big refactor after but I'm doing as much as I can with 0 rebuilds first | 16:47:26 |
21 Oct 2024 |
| (artur 'manuel) changed their display name from (lambda (f l) (format nil "~a ~a")) "Artur" "Manuel" to (artur 'manuel). | 20:03:25 |
23 Oct 2024 |
| luna-null changed their display name from Autumn to luna-null. | 09:49:25 |
emily | it is time https://github.com/NixOS/nixpkgs/pull/350736 | 15:43:56 |
25 Oct 2024 |
| lholh joined the room. | 03:54:16 |
| lholh left the room. | 22:42:31 |
29 Oct 2024 |
| eva removed their profile picture. | 22:26:33 |
| eva set a profile picture. | 22:26:42 |
30 Oct 2024 |
| Tomodachi94 (they/them) joined the room. | 01:26:47 |
Tomodachi94 (they/them) | What are our thoughts about dropping gradle_6 after the feature freeze? Support ended almost two years ago: https://endoflife.date/gradle | 04:37:03 |
Infinidoge 🏳️⚧️ | Sounds reasonable to me | 04:37:53 |
Tomodachi94 (they/them) | Additionally, it is very insecure, with four CVEs that are only patched in v7 or higher: https://github.com/NixOS/nixpkgs/pull/352236 | 04:38:02 |
Tomodachi94 (they/them) | Only three packages are using it | 04:38:44 |