8 Jan 2025 |
nbathum | its not exactly a review, but i've verified the builds on x86_64-linux | 15:45:52 |
emily | a little worried about the amount of code to handle versions that we wouldn't ever want to ship in a stable release | 15:47:50 |
emily | when is the 24 release due again? (I feel like I asked this before but forgot) | 15:48:13 |
nbathum | the schedule on openjdk site says that 2025/03/18 is the target for General Availability | 15:57:26 |
nbathum | raboof do you imagine testing java packages inside nixpkgs using this? | 16:01:44 |
raboof | yeah - so if we have a release schedule similar to https://github.com/NixOS/nixpkgs/issues/303285 that'd be well before the next branchoff | 16:04:28 |
raboof | that's fair. it's fairly mundane code though, and only executed when doing updates | 16:05:06 |
raboof | probably mainly outside. my first approach was indeed to package it outside of nixpkgs, but then I ran into the fact that there's quite some infrastructure inside of nixpkgs that is not easy to re-use outside (without resorting to copy-pasting), which is how I ended up doing it inside instead. | 16:09:55 |
raboof | having the binary package already in nixpkgs might also be convenient when we start packaging the source-built jdk24, as it looks like we currently bootstrap source-building of Java X with the corresponding binary Java X | 16:10:15 |
11 Jan 2025 |
| j4m3s joined the room. | 01:19:10 |
15 Jan 2025 |
| SomeoneSerge (utc+3) changed their display name from SomeoneSerge (utc+3) to SomeoneSerge. | 19:02:27 |
16 Jan 2025 |
| j4m3s set their display name to j4m3s. | 10:27:58 |
22 Jan 2025 |
| samasaur joined the room. | 19:54:23 |
samasaur | I'm not sure whether this is exactly the right place to put it, but I recently opened a PR attempting to standardize outputs of the JDKs in nixpkgs on darwin. It makes them produce a "JDK bundle" at $out/Library/Java/JavaVirtualMachines/${name}-${version}.jdk (mirroring the install location for JDKs on macOS), and provides a bundle attribute that points to this path. Having this consistency will make it a lot easier to install JDKs properly on darwin. I'd love to hear people's thoughts! | 19:57:48 |
31 Jan 2025 |
| SomeoneSerge (utc+3) changed their display name from SomeoneSerge to SomeoneSerge (Bruxelles). | 19:34:48 |
| raboof changed their display name from raboof to raboof@FOSDEM. | 23:54:20 |
2 Feb 2025 |
Tomodachi94 (they/them) | In reply to@samasaur:matrix.org I'm not sure whether this is exactly the right place to put it, but I recently opened a PR attempting to standardize outputs of the JDKs in nixpkgs on darwin. It makes them produce a "JDK bundle" at $out/Library/Java/JavaVirtualMachines/${name}-${version}.jdk (mirroring the install location for JDKs on macOS), and provides a bundle attribute that points to this path. Having this consistency will make it a lot easier to install JDKs properly on darwin. I'd love to hear people's thoughts! This sounds like an awesome idea, I'll take a look | 03:18:09 |
Tomodachi94 (they/them) | I currently don't have access to a NixOS machine though, so I'm limited to just reviewing diffs (this is why I've been so inactive this month) | 03:18:35 |
Tomodachi94 (they/them) | This is totally up @emily's alley too (darwin and Java) | 03:32:54 |
samasaur | yeah i was actually talking with emily about it when i did the work originally! they get credit for the idea of putting JDK bundles at the path that mirrors the install location | 03:44:43 |
samasaur | i'll request their review too | 03:48:49 |
samasaur | and I just force-pushed | 03:49:19 |
samasaur | As best I can tell, the PR doesn't introduce any new breakages | 03:49:39 |
Tomodachi94 (they/them) | I've been meaning to mark a bunch of those Java packages as broken since I did some Ant refactors way back in November/early December, could be a fun project for anyone wanting to do Java stuff | 04:49:46 |
Tomodachi94 (they/them) | (and potentially make the build reports of some of my PRs more appealing, which is totally unrelated /s 🙃) | 04:50:38 |
| gmodena joined the room. | 10:54:57 |
samasaur | funnily enough i actually realized while doing this that I barely use Java anymore | 18:41:55 |
samasaur | I still keep four JDK versions installed on my mac though | 18:42:12 |
samasaur | and now I'm committed to getting this queue of changes in | 18:42:38 |
| raboof changed their display name from raboof@FOSDEM to raboof. | 22:18:45 |