24 May 2024 |
Infinidoge 🏳️⚧️ | I need to just stop doing PRs to staging, every time I rebase it just ends badly | 17:50:13 |
Infinidoge 🏳️⚧️ | I'm just gonna split up the mass bump PR, I just want this done and over with | 17:50:57 |
Infinidoge 🏳️⚧️ | I've put far too much of my time and effort into polishing this one PR and I've gotten unreasonably attached to it being 'my' victory getting it done and that's anti-collaborative | 17:51:28 |
Philip Taron (UTC-8) | I need something (maybe a git hook?) to stop me from pushing if the PR isn't marked draft. | 17:51:35 |
Philip Taron (UTC-8) | Because: same, Infinidoge 🏳️⚧️ . | 17:51:52 |
Infinidoge 🏳️⚧️ | I know it's gotten bad when I am slightly frustrated seeing someone else split the PR and merge it in because it feels like it diminishes from the grant "This does everything!" PR when ultimately it's solving the problem faster | 17:53:05 |
Infinidoge 🏳️⚧️ | Just | 17:53:07 |
Infinidoge 🏳️⚧️ | Ugh | 17:53:08 |
bendlas | yeah, better to always maintain your outbox such that you're proud when someone takes from it ^^ | 17:54:20 |
Infinidoge 🏳️⚧️ | GitHub should make it so that it doesn't implicitly pull in code owners, and instead blocks merging until code owners are requested for review and provide their reviews | 17:54:38 |
Infinidoge 🏳️⚧️ | Then you wouldn't end up with this mass ping problem by accident | 17:54:53 |
Infinidoge 🏳️⚧️ | A Git hook that blocks rebases from too far down would also be nice | 17:55:04 |
Infinidoge 🏳️⚧️ | But those are thoughts for later | 17:55:08 |
Infinidoge 🏳️⚧️ | In reply to@bendlas:matrix.org yeah, better to always maintain your outbox such that you're proud when someone takes from it ^^ Easier said then done, sadly, I put far too much stake in doing things myself when I shouldn't | 17:56:37 |
bendlas | In reply to @infinidoge:inx.moe Easier said then done, sadly, I put far too much stake in doing things myself when I shouldn't been there, done that (for far too long) ... the spoils of youth 😅 enjoy it while it lasts. before you know it, you might also start cheering for anybody who takes work off your hands | 18:02:28 |
Philip Taron (UTC-8) | Yeah, there are some upsides to feeling a sense of ownership! And I celebrate your willingness to go through the pain of trying to get this better, including some of this dang self-inflicted pain. | 18:03:29 |
Philip Taron (UTC-8) | Feel free to tag me on the new PR when it lands. | 18:10:19 |
Infinidoge 🏳️⚧️ | Will do, anyone else want to be CCed on the PRs? | 20:48:02 |
Infinidoge 🏳️⚧️ | (Making multiple) | 20:48:05 |
Infinidoge 🏳️⚧️ | Now that I've generated a sufficient number of pings today | 20:59:18 |
Infinidoge 🏳️⚧️ | https://github.com/NixOS/nixpkgs/pull/314377
https://github.com/NixOS/nixpkgs/pull/314378
https://github.com/NixOS/nixpkgs/pull/314380
https://github.com/NixOS/nixpkgs/pull/314381
https://github.com/NixOS/nixpkgs/pull/314384 | 20:59:48 |
Philip Taron (UTC-8) | 👀 | 21:00:13 |
Infinidoge 🏳️⚧️ | Now these PRs shall hopefully be small enough such that they will each be merged within my lifetime | 21:00:36 |
Philip Taron (UTC-8) | https://github.com/NixOS/nixpkgs/pull/314377 -- nixpkgs-review says it'll rebuild 890 packages | 21:03:17 |
Philip Taron (UTC-8) | That's like on the edge for master rebuilds, as I understand it. | 21:03:42 |
Infinidoge 🏳️⚧️ | I expect several of these will get moved to staging, I'm mostly just waiting for OfBorg to eval them first | 21:10:58 |
Infinidoge 🏳️⚧️ | I'm not going another master<->staging rebase today, I've already failed at that once today lol | 21:11:20 |
Infinidoge 🏳️⚧️ | * I'm not going another master<->staging rebase today, I've already failed at that once earlier lol | 21:11:26 |
Infinidoge 🏳️⚧️ | Gah | 21:13:12 |
Infinidoge 🏳️⚧️ | Every single time | 21:13:14 |