| 23 Nov 2024 |
 emily | I'm a bit unclear on "Should I draftify the setup hook PR and reuse it for all of the refactors, then undraft it once it's done?" then | 01:24:01 |
 Tomodachi94 (they/them) | In reply to@emilazy:matrix.org
I'm a bit unclear on "Should I draftify the setup hook PR and reuse it for all of the refactors, then undraft it once it's done?" then Basically turning the setup hook PR into a draft and repurposing it for all of the refactors | 01:24:27 |
| Tomodachi94 (they/them) | Probably retitling it ant: refactor. Or would a new PR be better to avoid creating a hellthread until the very end when it's undrafted? | 01:25:21 |
| emily | it seems best just to merge it as-is and then build on top of it? | 01:25:37 |
| Tomodachi94 (they/them) | I agree :) | 01:25:53 |
| Tomodachi94 (they/them) | * I don't anticipate many regressions with the other three big changes I have planned (splitting ant-contrib, removing our custom wrapper, which leads into building from source) | 01:32:56 |
| Tomodachi94 (they/them) | * I don't anticipate many regressions with the other three big changes I have planned (splitting ant-contrib and removing our custom wrapper, which leads into building from source) | 01:33:11 |
| Tomodachi94 (they/them) | Yay release notes merge conflicts /s | 01:44:20 |
| Tomodachi94 (they/them) | re. @Toma's comment on the PR: I think I have caught all of the regressions, does that ease your mind at all about including the hook in the core ant package? | 01:46:15 |
| emily | I recommend antHook or ant.hook, there is some desire to move away from implicit hooks in general | 01:47:34 |
| emily | e.g. from cmake to cmakeHook or such | 01:47:39 |
| emily | beginners generally find it confusing that adding a dependency restructures how their entire build works, and separate hooks give us natural configuration points to do things like e.g. propagating Ninja for faster CMake builds without polluting the CMake package itself | 01:48:22 |
