Sender | Message | Time |
---|---|---|
27 Mar 2025 | ||
On the testing PRs bit, our CONTRIBUTING.md is quite good nowadays: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-to-review-pull-requests As for testing prerelease branches, we have a system called Hydra which builds packages automatically once they're promoted to a channel. Here's some more information: https://wiki.nixos.org/wiki/Channel_branches | 04:26:46 | |
* On the testing PRs bit, our CONTRIBUTING.md has some good advice: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-to-review-pull-requests As for testing prerelease branches, we have a system called Hydra which builds packages automatically once they're promoted to a channel. Here's some more information: https://wiki.nixos.org/wiki/Channel_branches | 04:27:01 | |
* On the testing PRs bit, our CONTRIBUTING.md has some good advice: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-to-review-pull-requests As for testing prerelease branches, we have a system called Hydra which builds packages automatically once they're promoted (id that the right word?) to a channel. Here's some more information: https://wiki.nixos.org/wiki/Channel_branches | 04:27:26 | |
* On the testing PRs bit, our CONTRIBUTING.md has some good advice: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-to-review-pull-requests As for testing prerelease branches, we have a system called Hydra which builds packages automatically once they're promoted (is that the right word?) to a channel. Here's some more information: https://wiki.nixos.org/wiki/Channel_branches | 04:27:34 | |
In reply to @tomodachi94:matrix.orgI mostly just don't have the time, I'm afraid :) | 12:18:30 | |
I'm happy to try and take a look at stuff I'm pointed out, and do specific bits of work when they dovetail with other stuff I want to do, but if I try to track all the day to day Java stuff I'll just drop the ball on stuff more than I already do | 12:19:03 | |
FWIW I don't think JDK patch updates need more testing than confirming build and maybe a brief perusal of advisories/release notes | 12:20:39 | |
just needs someone keeping track of them (r-ryantm sometimes has issues and isn't always the fastest) and a committer who can allocate the time to merging them | 12:21:33 | |
Jup. While I think everyone wants to run newer JDKs, many libraries want to support running on JDK8, and the easiest way to achieve that is by building on JDK8 - building with a newer JDK than the target JDK only became reliable when targeting JDK9 onwards... | 14:15:38 | |
I wonder if it'd be easier to drop jdk11 than it'd be to drop jdk8 | 14:17:02 | |
no promises but feel free to request reviews from me on (especially already-maintainer-reviewed) Java PRs for merge | 14:19:06 | |
30 Mar 2025 | ||
02:13:21 | ||
1 Apr 2025 | ||
09:41:46 | ||
5 Apr 2025 | ||
14:18:43 | ||
8 Apr 2025 | ||
samasaur: could you maybe take a look at https://hydra.nixos.org/build/294329205/nixlog/1 ? | 10:15:17 | |
looks like it was caused by your PR | 10:16:30 | |
ah i see it | 20:25:09 | |
looks like it has already been fixed: https://github.com/NixOS/nixpkgs/commit/7a14f3c857ac979132b782e82b0f5979a833dcc3 | 20:25:14 | |
yeah we were discussing it in #staging:nixos.org | 20:32:40 | |
I'm not sure how that happened, I know I tested building these locally, and I can't really imagine how this bug would have been introduced when I rebased onto stagin | 20:32:51 | |
* I'm not sure how that happened, I know I tested building these locally, and I can't really imagine how this bug would have been introduced when I rebased onto staging | 20:32:54 | |
just checked and apparently the symlink was broken before my rebase too but the build was successful anyway? baffling | 20:55:46 | |
oh, I think the symlink check was tweaked for Darwin this cycle | 20:59:24 | |
something about how symlinks can have their own permissions in XNU | 20:59:31 | |
ah gotcha | 21:02:33 | |
i learned that recently, although permissions on the link itself don't seem to be consistently applied | 21:02:52 | |
stat and cat are able to follow a link even after i chmod it to 000 and chown it to root, but readlink /realpath and ls /eza cannot | 21:03:06 | |
9 Apr 2025 | ||
07:41:09 | ||
19 Apr 2025 | ||
Did we ever decide if the Java team has any blocking items for 25.05? | 02:15:00 | |
OpenJDK 23 is EOL now/soon, so that would be good to drop. Though OpenJDK 24 will also be EOL in the release cycle. Do we have a policy for non-LTS JDK versions on stable? | 07:58:37 |