| 21 Nov 2024 |
 Tomodachi94 (they/them) | (Say I've never rebased onto staging without saying I've never rebased onto staging) | 02:06:02 |
 emily | that's the new ofborg thing | 02:07:00 |
| emily | probably nothing to do with you | 02:07:03 |
| Tomodachi94 (they/them) | I bet that the new workflow requires a file introduced less than 24 hours ago, and it simply hasn't synced from master yet | 02:31:39 |
| Tomodachi94 (they/them) | Bingo. https://github.com/NixOS/nixpkgs/commit/6d2d99ef570f01035e93a79beba079cae5843d10 was made 7 hours ago, but https://github.com/NixOS/nixpkgs/commits/staging/.github on staging shows no changes for 5 days | 02:34:52 |
| Tomodachi94 (they/them) | Bingo. https://github.com/NixOS/nixpkgs/commit/6d2d99ef570f01035e93a79beba079cae5843d10 was made 7 hours ago, but https://github.com/NixOS/nixpkgs/commits/staging/.github on staging shows no changes in .github for 5 days | 02:35:40 |
| Tomodachi94 (they/them) | * I bet that the new workflow requires a file introduced less than 24 hours ago, and it simply hasn't synced from master to staging yet | 02:35:58 |
| Tomodachi94 (they/them) | Bingo. https://github.com/NixOS/nixpkgs/commit/6d2d99ef570f01035e93a79beba079cae5843d10 was made 17 hours ago, but https://github.com/NixOS/nixpkgs/commits/staging/.github on staging shows no changes in .github for 5 days | 02:37:35 |
| Tomodachi94 (they/them) | (TLDR: not my fault) | 02:43:15 |
| Tomodachi94 (they/them) | Test added for the external task finding logic. I can add tests for the other parts if that's desired | 17:38:53 |
| Tomodachi94 (they/them) | * Test added for the external-task-finding logic. I can add tests for the other parts if that's desired | 17:39:02 |
| Tomodachi94 (they/them) | Test added for the external-task-finding logic. I can add tests for the other parts if that's desired (I didn't do it because I'd have to write a build.xml from scratch, which I'm fine with doing, but it takes time) | 17:39:55 |
| Tomodachi94 (they/them) | Update: tried to do that, I get strange errors relating to XML parsing | 18:27:37 |
| Tomodachi94 (they/them) | (Very specific /s, org/xml/sax/SAXParseException) | 18:28:55 |
| Tomodachi94 (they/them) | (Very specific /s, org/xml/sax/SAXParseException with no further information) | 20:35:56 |
| Tomodachi94 (they/them) | More information about my plans to rip out ant-contrib from the main ant package: https://github.com/NixOS/nixpkgs/issues/357758 | 22:02:41 |
| Tomodachi94 (they/them) | (Ideally this would go into the same staging cycle as the Ant setup hook PR for reasons listed in that issue and the PR) | 22:03:17 |
| Tomodachi94 (they/them) | * (Ideally this would go into the same staging cycle as the Ant setup hook PR) | 22:03:26 |
| emily | probably a week or two out from staging-next FWIW | 22:06:22 |
| Tomodachi94 (they/them) | Thanks ❤️ reviews are appreciated as always | 22:07:39 |
| Tomodachi94 (they/them) | Most of the complexity in the PR comes from allowing consumers to set flags (I'd say at least half of the SLOC is that) | 22:08:29 |
| emily | yeah, poke me in a few days (if everything is ready) and I'll try to look. trying to take it easy for a few days (we'll see if I manage 🙃) | 22:08:32 |
| Tomodachi94 (they/them) | In reply to@emilazy:matrix.org
yeah, poke me in a few days (if everything is ready) and I'll try to look. trying to take it easy for a few days (we'll see if I manage 🙃) For sure ❤️ hope you can find time to rest | 22:11:27 |
| 22 Nov 2024 |
| Tomodachi94 (they/them) | I'm wondering if we should move the ANT_HOME to $out/share/ant instead of $out/lib/ant before we hard-code that path in the findExternalAntTasks of the setup hook | 16:49:54 |
| Tomodachi94 (they/them) | I'm gonna do that, in a separate PR though | 17:02:42 |
| Tomodachi94 (they/them) | share/ant is the convention used by Debian and possibly others | 17:04:41 |
| Tomodachi94 (they/them) | ...and tons more too, see PR description: https://github.com/NixOS/nixpkgs/pull/358204 | 17:31:00 |
| Tomodachi94 (they/them) | * ...and tons of other distros too, see PR description: https://github.com/NixOS/nixpkgs/pull/358204 | 17:36:09 |
|  Morgan (@numinit) joined the room. | 17:50:01 |
| Tomodachi94 (they/them) | Welcome :) | 18:06:14 |
