| 9 Nov 2024 |
Tomodachi94 (they/them) | * Undrafted https://github.com/NixOS/nixpkgs/pull/352938 since it's been a week. Also rebased onto master to resolve a merge conflict caused by the by-name migration | 19:21:21 |
| 10 Nov 2024 |
| @sbc64:matrix.org left the room. | 20:02:07 |
Tomodachi94 (they/them) | Just curious: Are there technical reasons for being unable to use OpenJDK 8 on Darwin? Or is it just a lot of work? | 21:20:08 |
emily | JDK 8 was released like 8 years before Apple Silicon | 21:47:30 |
emily | (x86_64-darwin is another matter) | 21:47:35 |
emily | the patches to port it to aarch64-darwin aren't upstream because apparently they need work or something | 21:47:51 |
emily | Zulu patch it downstream | 21:48:00 |
emily | (but Temurin don't offer aarch64-darwin builds for JDK 8, so we can't bootstrap that way) | 21:48:15 |
emily | I don't think it really matters since JDK 8 will have dwindling use over its final two years of lifespan anyway | 21:48:49 |
emily | and all aarch64-darwin users can use an x86_64-darwin JDK via Rosetta 2 | 21:49:01 |
Tomodachi94 (they/them) | Off-topic: I made a GitHub Project for Java things so that we can hopefully coordinate Java things better in the future. https://github.com/orgs/NixOS/projects/86 | 22:34:33 |
| 11 Nov 2024 |
| benjaminedwardwebb set a profile picture. | 00:58:30 |
| benjaminedwardwebb changed their profile picture. | 01:01:06 |
Tomodachi94 (they/them) | * Off-topic: I made a GitHub Project for Java things so that we can hopefully coordinate said Java things better in the future. https://github.com/orgs/NixOS/projects/86 | 05:05:19 |
Tomodachi94 (they/them) | https://github.com/NixOS/nixpkgs/pull/355153 | 19:19:48 |
Tomodachi94 (they/them) | Unfortunately, some Maven plugins misbehave and include the date regardless of that setting | 19:20:22 |
Tomodachi94 (they/them) | Unfortunately, some Maven plugins misbehave and include the date regardless of that setting (such as jipsy used in vatprism) | 19:22:40 |
Tomodachi94 (they/them) | Unfortunately, some Maven plugins misbehave and include the date regardless of that setting (such as the old version of jipsy used in vatprism) | 19:29:03 |
emily | I think this should be a hook | 19:34:57 |
Tomodachi94 (they/them) | I concur:
I'm also not fond of the way that we append to postPatch; we should consider moving this builder to setup hooks, which is what the Rust builders and other builders do.
| 20:21:00 |
Tomodachi94 (they/them) | Wait, do you mean moving just the patcher to a new setup hook, or moving everything to a setup hook? | 20:21:46 |
emily | just the patcher | 20:21:59 |
emily | I mean | 20:22:06 |
emily | the build stuff should also be a hook | 20:22:10 |
emily | but the postPatch thing should be a hook also | 20:22:17 |
emily | it could be just a phase in a larger setup hook | 20:22:30 |
emily | if that was done | 20:22:33 |
Tomodachi94 (they/them) | Maybe I'll draft this PR and refactor everything already present to be hooks in a new PR, then refactor the current PR once that is merged | 20:23:13 |
| 12 Nov 2024 |
Tomodachi94 (they/them) | Hmm let's maybe not refactor the buildMavenPackage build story today 🫠| 00:35:22 |
Tomodachi94 (they/them) | (Codespaces warned me that I'm at 90% usage and it doesn't reset until Nov 22) | 00:36:48 |