| 3 Nov 2024 |
Tomodachi94 (they/them) | source-1.7.15.jar is identical to their rhino-1.7.15.jar except for NativeCollectionIterator$1.class and NativePromise$1.class (both in theirs but not ours) according to a diff --recursive of the extracted JARs | 03:55:50 |
emily | diffoscope time | 03:55:57 |
Tomodachi94 (they/them) | It's all bytecode 💔 | 03:56:13 |
Tomodachi94 (they/them) | There are differences in the files too, but I'm chalking that up to different Java versions | 03:56:43 |
Tomodachi94 (they/them) | * There are differences in many files too, but I'm chalking that up to different Java versions | 03:56:49 |
Tomodachi94 (they/them) | Our source.jar has xml, tools, but no engine subdirectory | 03:59:41 |
emily | I think diffoscope can decompile Java. | 04:03:09 |
Infinidoge 🏳️⚧️ | In reply to @tomodachi94:matrix.org Oh, hmm. A discussion on their GitHub says to use ./gradlew :rhino-all:shadowJar, but setting gradleBuildTask = ":rhino-all:shadowJar" fails because Gradle can't find such a task Which is odd, since running ./gradlew in the repo can find it just fine | 05:56:59 |
Infinidoge 🏳️⚧️ | My guess is the gradle infrastructure is creating a "phantom" project that's missing the necessary tasks, annoyingly | 06:06:48 |
Tomodachi94 (they/them) | Looking at the Ant package right now: https://github.com/NixOS/nixpkgs/blob/d0d0a083585193d7a5c0bb0a7172b3f7a975beb6/pkgs/development/tools/build-managers/apache-ant/default.nix#L14-L17
| 08:08:45 |
Tomodachi94 (they/them) | Should ant-contrib be its own package?
| 08:08:58 |
Tomodachi94 (they/them) | Updated Ant to 1.10.15, and made it an update script: https://github.com/NixOS/nixpkgs/pull/353301
| 08:17:00 |
Tomodachi94 (they/them) | In reply to@tomodachi94:matrix.org
Thiago politely declined, I pinged shlevy and NeQuissimus on GitHub here: https://github.com/NixOS/nixpkgs/pull/352938
Was this the correct way to establish a team, or is there an established process I'm supposed to follow? | 20:39:33 |
emily | just gotta ping the org owners a couple times sometimes :) | 20:46:27 |
Tomodachi94 (they/them) | In reply to@tomodachi94:matrix.org
Updated Ant to 1.10.15, and made it an update script: https://github.com/NixOS/nixpkgs/pull/353301
Is this fine to go to master, or should we do this on staging? :) | 20:49:43 |
Tomodachi94 (they/them) | 100-500 rebuilds according to our beloved Borgo | 20:50:01 |
emily | rebuilds look fine for master | 20:50:17 |
emily | do you have the spare cycles to run a nixpkgs-review? | 20:56:09 |
emily | it shouldn't be too bad with that rebuild count | 20:56:14 |
emily | unless LibreOffice is one of those builds :) | 20:56:30 |
Tomodachi94 (they/them) | In reply to@emilazy:matrix.org do you have the spare cycles to run a nixpkgs-review? I don't unfortunately. I'm currently using the Codespaces free plan to contribute to Nixpkgs (it works, I just have to prefix all of the Nix commands with sudo) | 20:57:23 |
Tomodachi94 (they/them) | (Yes, it is as cursed as it sounds) | 20:57:51 |
emily | wow | 20:57:54 |
emily | you need to find an old ThinkPad in a swamp somewhere | 20:58:21 |
Tomodachi94 (they/them) | For sure haha | 20:58:50 |
emily | you know about the community builders right? | 20:59:51 |
emily | I'd be happy to vouch if you wanted to request accounts on them | 21:00:00 |
emily | we have aarch64-linux, x86_64-linux and aarch64-darwin (hence also x86_64-darwin) | 21:00:08 |
emily | https://github.com/NixOS/aarch64-build-box, https://nix-community.org/community-builder/ | 21:02:35 |
Tomodachi94 (they/them) | In reply to@emilazy:matrix.org I'd be happy to vouch if you wanted to request accounts on them That'd be awesome ❤️ I'll submit PRs ont | 21:03:01 |