| 23 Nov 2024 |
 emily | e.g. from cmake to cmakeHook or such | 01:47:39 |
| emily | beginners generally find it confusing that adding a dependency restructures how their entire build works, and separate hooks give us natural configuration points to do things like e.g. propagating Ninja for faster CMake builds without polluting the CMake package itself | 01:48:22 |
| emily | (haven't seen the comment, maybe what I'm saying is irrelevant) | 01:48:31 |
 Tomodachi94 (they/them) | In reply to@emilazy:matrix.org
(haven't seen the comment, maybe what I'm saying is irrelevant) Completely relevant, Toma mentioned that the alphabet causes regressions because of the implicit hook (the big one was that ant comes before cmake) | 01:49:49 |
| Tomodachi94 (they/them) | (Aside: The Alphabet of Nixpkgs) | 01:50:03 |
| Tomodachi94 (they/them) | * (Aside: The Alphabet of Nixpkgs song when /lh) | 01:50:14 |
| emily | guess we'll have to pin an old version of the alphabet | 01:50:31 |
| Tomodachi94 (they/them) | Don't forget to add it to stdenv! | 01:51:00 |
| Tomodachi94 (they/them) | In reply to@emilazy:matrix.org
I recommend antHook or ant.hook, there is some desire to move away from implicit hooks in general Thinking about this more, this would also mean that we wouldn't need to put this PR into staging (we'd need to put the other refactors in there though), since the Ant package's closure is unchanged | 02:56:21 |
| Tomodachi94 (they/them) | Thus, it's also infinitely easier to review | 02:56:39 |
| Tomodachi94 (they/them) | * Thus, it's also infinitely easier to review (rebuild a few packages vs all 800 dependencies) | 02:57:00 |
| Tomodachi94 (they/them) | * Thus, it's also infinitely easier to review (rebuild a few packages vs all 800 dependencies), so I'll be unblocked faster | 02:58:38 |
| emily | sgtm | 02:58:51 |
| Tomodachi94 (they/them) | * Thus, it's also infinitely easier to review (rebuild a few select packages vs all 800 dependencies), so I'll be unblocked faster | 02:59:12 |
| Tomodachi94 (they/them) | You're good at talking people out of bad design decisions :) | 03:00:11 |
| emily | sometimes I talk people into them just to shake it up 😈 | 03:00:39 |
| Tomodachi94 (they/them) | To hardcode or not to hardcode the path to the Ant executable, that is the question | 03:04:03 |
| Tomodachi94 (they/them) | * To hardcode or not to hardcode the path to the Ant executable in the hook, that is the question | 03:04:13 |
| Tomodachi94 (they/them) | Okay, refactored everything to use a separate ant.hook package, down to 6 commits (versus the 14 before) | 03:41:45 |
| Tomodachi94 (they/them) | Presumably rebuilds are under 20 now (being generous with the amount of indirect dependencies) | 03:44:30 |
| Tomodachi94 (they/them) | vuze... needs some TLC, if it's even maintained upstream anymore | 04:02:32 |
| emily | it is not | 04:03:48 |
| Tomodachi94 (they/them) | Oh wonderful, CVE with a 9.8 severity from 2018. Last time the package was updated was 2017 | 04:12:49 |
| Tomodachi94 (they/them) | (CVE-2018-13417 for the curious) | 04:13:44 |
| emily | 🤪 | 04:16:59 |
| emily | time for the knownVulnerabilities + removal dance | 04:17:06 |
| Tomodachi94 (they/them) | You know it! About to do the first movement, titled vuze: drop | 04:18:13 |
| emily | oh it's broken = true; | 04:31:00 |
| emily | not exactly security critical then | 04:31:19 |
| emily | Tomodachi94 (they/them): can you move the release note to 24.11 | 04:31:36 |
