| 22 Sep 2025 |
msgilligan | This is cool:
nativeBuildInputs = [
gradle
gradle.jdk # one of the tests also require that the `java` command is available on the command line
makeWrapper
];
| 18:21:36 |
msgilligan | * This is cool (TIL!):
nativeBuildInputs = [
gradle
gradle.jdk # one of the tests also require that the `java` command is available on the command line
makeWrapper
];
| 18:22:15 |
msgilligan | tempFileManagement_defaults_and_overrides() | 18:24:06 |
msgilligan | org.opentest4j.AssertionFailedError: expected: </var/folders/6d/12xt4b4m8xjf3t0059_w18bh0000gn/T/stirling-pdf> but was: </var/folders/6d/12xt4b4m8xjf3t0059_w18bh0000gn/T//stirling-pdf>
at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at app//org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
at app//org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
at app//stirling.software.common.model.ApplicationPropertiesLogicTest.tempFileManagement_defaults_and_overrides(ApplicationPropertiesLogicTest.java:40)
at java.base@24.0.2/java.lang.reflect.Method.invoke(Method.java:565)
at java.base@24.0.2/java.util.ArrayList.forEach(ArrayList.java:1604)
at java.base@24.0.2/java.util.ArrayList.forEach(ArrayList.java:1604)
| 18:24:23 |
msgilligan | For some reason macOS adds an extra / in this path:
/var/folders/6d/<hash>/T//stirling-pdf | 18:25:24 |
msgilligan | * ApplicationPropertiesLogicTest
tempFileManagement_defaults_and_overrides() | 18:26:01 |
msgilligan | I posted macOS test results in a thread above. | 18:29:39 |
Benedikt Ritter (britter) | I kind of started the same way. I wanted a better solution for managing my home environment than putting random text files into a git repository. When I found home manager it was RIP https://github.com/britter/dotfiles | 18:29:44 |
Benedikt Ritter (britter) | yeah, so it's not a problem related to packaging this app in nixpkgs. It's just that the tests don't work on macOS. For that reason this problem should not block a merge. We can discuss whether we want to create a PR for the project to get it fixed or whether we just set doCheck = false and move on with our lives... | 18:31:06 |
msgilligan | I'm working on a PR 🤣 | 18:36:59 |
msgilligan | Like the scorpion and the frog, but in a good way... | 18:37:09 |
msgilligan | I think the test just needs to use Paths.get(input).normalize() | 18:37:54 |
msgilligan | Function<String, String> normalize = s ->Paths.get(s).normalize().toString();
| 18:42:29 |
msgilligan | * Function<String, String> normalize = s ->Paths.get(s).normalize().toString();
| 18:42:36 |
Benedikt Ritter (britter) | Yeah. When you propose that as a PR there's a helper function in nixpkgs for pulling it as a patch. We can add that to my PR so it will build on macOS. | 18:47:10 |
msgilligan | Oh cool! | 18:47:25 |
msgilligan | Now I'm feeling less scorpion-like... | 18:47:42 |
Benedikt Ritter (britter) | I think it's called fetchPatch or something? An you can pass the URL to a github PR or there was a special URL for each PR that would just return the diff. | 18:56:02 |
Benedikt Ritter (britter) | If you give me the PR URL I can update my PR and you can try again. | 18:56:18 |
msgilligan | Fix for broken unit test on macOS in Stirling-PDF:
https://github.com/Stirling-Tools/Stirling-PDF/pull/4477 | 19:09:51 |
msgilligan | Posted directly in the room | 19:10:08 |
msgilligan | I'm looking forwarding to seeing this for the first time! | 19:23:18 |
msgilligan | I guess you'll leave the tests on so all I have to do is nixpkgs-review pr 445032, right? | 19:24:28 |
Benedikt Ritter (britter) | I updated the PR to pull the changed from your PR. Can you try again? | 19:26:59 |
msgilligan | Running... | 19:29:07 |
msgilligan | nixpkgs-review passes on both aarch64-darwin and aarch64-linux. The PR is also passing upstream CI: https://github.com/Stirling-Tools/Stirling-PDF/pull/4477/checks | 19:42:50 |
Benedikt Ritter (britter) | Thanks! | 19:44:06 |
msgilligan | You're welcome! | 19:44:25 |
msgilligan | I am benefitting so much from the Nix Gradle work you have done, that the balance is still heavily in your favor! | 19:45:32 |
msgilligan | Merged upstream. | 19:57:49 |