| 11 Nov 2024 |
 emily | I think this should be a hook | 19:34:57 |
 Tomodachi94 (they/them) | I concur:
I'm also not fond of the way that we append to postPatch; we should consider moving this builder to setup hooks, which is what the Rust builders and other builders do.
| 20:21:00 |
| Tomodachi94 (they/them) | Wait, do you mean moving just the patcher to a new setup hook, or moving everything to a setup hook? | 20:21:46 |
| emily | just the patcher | 20:21:59 |
| emily | I mean | 20:22:06 |
| emily | the build stuff should also be a hook | 20:22:10 |
| emily | but the postPatch thing should be a hook also | 20:22:17 |
| emily | it could be just a phase in a larger setup hook | 20:22:30 |
| emily | if that was done | 20:22:33 |
| Tomodachi94 (they/them) | Maybe I'll draft this PR and refactor everything already present to be hooks in a new PR, then refactor the current PR once that is merged | 20:23:13 |
| 12 Nov 2024 |
| Tomodachi94 (they/them) | Hmm let's maybe not refactor the buildMavenPackage build story today 🫠| 00:35:22 |
| Tomodachi94 (they/them) | (Codespaces warned me that I'm at 90% usage and it doesn't reset until Nov 22) | 00:36:48 |
| emily | GC time? | 00:37:05 |
| Tomodachi94 (they/them) | 90% compute, my bad. 90% storage too, but they do a weird thing to calculate your storage usage, "gigabyte-hours" | 00:38:02 |
| Tomodachi94 (they/them) | 90% compute, my bad. 90% storage too, but they do a weird thing to calculate your storage usage, "gigabyte-hours", so a GC wouldn't help very much, maybe a little | 00:38:24 |
| emily | we need to get you more community builder accounts :P | 00:38:24 |
| emily | wouldn't you be better off with, like, the cheapest eBay ThinkPad? | 00:38:42 |
| Tomodachi94 (they/them) | Probably :3 | 00:39:42 |
| Tomodachi94 (they/them) | Anyways, the patcher is now its own separate hook. I'll refactor the rest of the build story later | 00:55:23 |
| Tomodachi94 (they/them) | * Anyways, the patcher is now its own separate hook. I'll refactor the rest of the Maven build story later | 00:56:03 |
| Tomodachi94 (they/them) | (And after discovering that an appendToVar on postPatchHooks doesn't work, corrected to use preConfigurePhase) | 01:22:02 |
| emily | it should be a separate phase I think | 01:23:16 |
| Tomodachi94 (they/them) | Yep it is. I tried appendToVar postPatchPhases patchMavenPomHook and then appendToVar postPatchHooks patchMavenPomHook to no avail | 01:25:48 |
| Tomodachi94 (they/them) | Yep it is. I tried appendToVar postPatchPhases patchMavenPomHook and then appendToVar postPatchHooks patchMavenPomHook to no avail, only appendToVar preConfigureHooks patchMavenPomHook worked | 01:26:18 |
| Tomodachi94 (they/them) | Yep it is. I tried appendToVar postPatchPhases patchMavenPomHook and then appendToVar postPatchHooks patchMavenPomHook to no avail, only appendToVar preConfigurePhases patchMavenPomHook worked | 01:28:08 |
| emily | ah | 01:29:19 |
| 13 Nov 2024 |
|  Inayet joined the room. | 22:15:08 |
| 14 Nov 2024 |
| Tomodachi94 (they/them) | https://github.com/NixOS/nixpkgs/pull/256354 | 18:10:12 |
| Tomodachi94 (they/them) | Another day, another new JDK PR | 18:11:37 |
| Tomodachi94 (they/them) | * Another day, another new JDK addition | 18:11:47 |
