| 30 Oct 2024 |
emily | agree that dropping seems fine | 14:08:30 |
emily | so fwiw | 17:21:55 |
emily | it looks like the patch we already have is redundant with the Gradle 7 one | 17:22:10 |
emily | I'm definitely okay dropping it, but do you happen to have the error on hand with just the AUR patch + gradle_7? | 17:22:35 |
emily | (i can reproduce if not. just want to see if there's an easy fix we can do) | 17:22:47 |
Tomodachi94 (they/them) | I don't, I closed that shell session already 😔 It was something with variable schope iirc?
| 17:23:21 |
Tomodachi94 (they/them) | In reply to @emilazy:matrix.org I'm definitely okay dropping it, but do you happen to have the error on hand with just the AUR patch + gradle_7? https://github.com/NixOS/nixpkgs/pull/352422
| 17:23:50 |
emily | no need to wait for branch-off | 17:25:40 |
emily | we should not ship gradle_6 in 24.11 | 17:25:45 |
emily | I will spend a little bit of time trying to fix the package but if it doesn't bear fruit then we can drop it as depending on a vulnerable package and being effectively EOL | 17:26:09 |
emily | did you upgrade the mitm-cache deps when you tried? | 17:26:59 |
Tomodachi94 (they/them) | I did not | 17:27:43 |
emily | that would explain a fetch issue 😅 | 17:28:31 |
Tomodachi94 (they/them) | I used a standard non-NixOS Java environment with Gradle 7
| 17:28:34 |
emily | ah | 17:29:48 |
emily | I wonder if the AUR package is just broken | 17:30:20 |
Tomodachi94 (they/them) | I did get around it by adding mavenCentral to the repositories in build.gradle, resulting in the variable scoping error mentioned earlier
| 17:30:44 |
Tomodachi94 (they/them) | In reply to @emilazy:matrix.org no need to wait for branch-off Alright, I'll update this PR but keep it as a draft while you attempt to get it working
| 17:36:37 |
emily | we should just jd-cli first among the alternatives presumably btw | 17:37:02 |
Tomodachi94 (they/them) |
<@emilazy:matrix.org> no need to wait for branch-off
Alright, I'll update this PR to add a change note, but keep it as a draft while you attempt to get it working
| 17:37:08 |
emily | seeing as it will have the same semantics as the GUI | 17:37:10 |
Tomodachi94 (they/them) | Updated to include a changelog entry for 24.11, good luck :)
| 17:43:55 |
Tomodachi94 (they/them) | Off-topic: Thoughts on a Java/JDK team so that the maintainers of the Java/JDK/Java build systems can be pinged on the next release blockers issue?
| 17:47:56 |
Tomodachi94 (they/them) | Off-topic: Thoughts on a Java/JVM/JDK team so that the maintainers of the Java/JDK/Java build systems can be pinged on the next release blockers issue?
| 17:48:56 |
emily | sounds like a good idea except for my fear that I will get dragged in 😂 | 17:48:58 |
Tomodachi94 (they/them) | Created at https://github.com/orgs/NixOS/teams/jdk, I'll make a PR in a little bit
| 17:50:33 |
Tomodachi94 (they/them) | Any volunteers? 😂
| 17:50:40 |
emily | you'll need to get #org_owners:nixos.org to assign it to the Nixpkgs repository with triage permissions. you may also want to set it up in ci/OWNERS | 17:52:59 |
emily | btw, perhaps just "Java" would be a better name? | 17:53:20 |
emily | given "(JDK, JVM, Java, Gradle, Maven, Ant, and adjacent projects)" | 17:53:28 |