| 30 Oct 2024 |
 Tomodachi94 (they/them) | https://github.com/gradle/gradle/milestone/211 Doesn't look promising
| 05:50:15 |
| Tomodachi94 (they/them) | In reply to @emilazy:matrix.org
I'm about to sleep, but if you do the fetchpatch for jd-gui and get a removal PR up for gradle_6 I can merge them tomorrow morning worst-case On it :) rest well!
| 05:50:36 |
 emily | In reply to @tomodachi94:matrix.org
https://github.com/gradle/gradle/milestone/211 Doesn't look promising
otoh I'm seeing a YouTube video from a month ago saying it's coming, and other projects preemptively handling the deprecations | 05:51:07 |
| emily | I'm just thinking that this is going to be a lot more painful for 7. | 05:51:20 |
| emily | eh, maybe not so much. there's fewer users than I thought | 05:51:39 |
| Tomodachi94 (they/them) | Off-topic: Gradle supports Swift apparently... https://docs.gradle.org/current/samples/sample_building_swift_applications.html
| 05:53:15 |
| emily | the mess of a Swift derivation we have would go wonderfully with the Gradle MITM cache stuff | 05:58:52 |
| Tomodachi94 (they/them) | Yummy, an error involving MavenOrgSourceLoaderProvider
| 06:03:35 |
| Tomodachi94 (they/them) | Yummy, an error involving MavenOrgSourceLoaderProvider on jd-gui
| 06:03:56 |
| Tomodachi94 (they/them) | Oh, not as bad as expected, that file isn't used in the build process. Scared me briefly
| 06:04:57 |
| emily | is that after applying the aur patch I linked? | 06:05:56 |
| Tomodachi94 (they/them) | Yep. A different error occurs if I try gradle_7 instead of _8
| 06:06:25 |
| emily | well, good luck :) I'll check in tomorrow | 06:06:46 |
| Tomodachi94 (they/them) | This isn't the first time we had to patch jd-gui to work with a newer Gradle: https://github.com/NixOS/nixpkgs/pull/205841
| 06:19:42 |
| Tomodachi94 (they/them) | A while later, I spent a substantial amount of time trying to get a development environment so I could even start making a patch, but Gradle couldn't download jd-core. Considering upstream has had no activity in ~5 years, might be time to drop it
| 07:01:42 |
| Tomodachi94 (they/them) | Additionally, the AUR patch conflicts with another patch that we already have on the package
| 07:03:09 |
| Tomodachi94 (they/them) | It's currently very late where I am, I'll take another shot at this tomorrow :)
| 07:04:21 |
| emily | agree that dropping seems fine | 14:08:30 |
| emily | so fwiw | 17:21:55 |
| emily | it looks like the patch we already have is redundant with the Gradle 7 one | 17:22:10 |
| emily | I'm definitely okay dropping it, but do you happen to have the error on hand with just the AUR patch + gradle_7? | 17:22:35 |
| emily | (i can reproduce if not. just want to see if there's an easy fix we can do) | 17:22:47 |
| Tomodachi94 (they/them) | I don't, I closed that shell session already 😔 It was something with variable schope iirc?
| 17:23:21 |
| Tomodachi94 (they/them) | In reply to @emilazy:matrix.org
I'm definitely okay dropping it, but do you happen to have the error on hand with just the AUR patch + gradle_7? https://github.com/NixOS/nixpkgs/pull/352422
| 17:23:50 |
| emily | no need to wait for branch-off | 17:25:40 |
| emily | we should not ship gradle_6 in 24.11 | 17:25:45 |
| emily | I will spend a little bit of time trying to fix the package but if it doesn't bear fruit then we can drop it as depending on a vulnerable package and being effectively EOL | 17:26:09 |
| emily | did you upgrade the mitm-cache deps when you tried? | 17:26:59 |
| Tomodachi94 (they/them) | I did not | 17:27:43 |
| emily | that would explain a fetch issue 😅 | 17:28:31 |
