| 29 Apr 2024 |
@infinidoge:matrix.org | In reply to @philiptaron:matrix.org I'll gladly give way if there's something more thorough in the works! I have a massive bump PR that goes through basically every JDK in Nixpkgs, but it's so big that it's been stalled for months now lol | 15:47:13 |
@infinidoge:matrix.org | Now that the semester is ending I'm kicking myself into actually finishing it | 15:47:26 |
Philip Taron (UTC-8) | Figuring out how to split these things up is usually the most work. 😩 | 15:47:46 |
@infinidoge:matrix.org | Yep | 15:47:55 |
Philip Taron (UTC-8) | I appreciated the PR you made that had a nice split; it made me feel like it was possible to just increment my way toward a JVM bump. | 15:48:17 |
@infinidoge:matrix.org | What we really need in nixpkgs is better automation for JDK bumps in general, and more code reuse between them | 15:48:50 |
@infinidoge:matrix.org | Because right now it is a mess | 15:48:56 |
@infinidoge:matrix.org | It's a sisyphean task though | 15:49:39 |
Philip Taron (UTC-8) | It's pretty similar to the LLVM situation before https://matrix.to/#/@rosscomputerguy:matrix.org made https://github.com/NixOS/nixpkgs/pull/299807 | 15:50:55 |
Philip Taron (UTC-8) | If you like how this PR tastes, I'm planning on doing the same update for semeru-bin. | 15:55:29 |
@infinidoge:matrix.org | Wait | 16:37:55 |
@infinidoge:matrix.org | Temurin bin 23 exists? | 16:38:01 |
@infinidoge:matrix.org | OpenJDK 23 doesn't exist yet, how does temurin have a 23 release | 16:38:12 |
@infinidoge:matrix.org | Unless that's just Java mainline | 16:39:03 |
@infinidoge:matrix.org | The website only lists up to 22 | 16:39:30 |
Philip Taron (UTC-8) | 🤔 | 16:39:48 |
Philip Taron (UTC-8) | I marked the PR as draft because I messed up something and got an eval failure. I think it's related to the 23 thing. | 16:40:27 |
@infinidoge:matrix.org | Yeah I'm pretty sure JDK 23 just doesn't exist lol | 16:41:00 |
@infinidoge:matrix.org | The eval failure is probably because it didn't get any sources for 23 | 16:41:20 |
@infinidoge:matrix.org | In reply to @philiptaron:matrix.org I'll gladly give way if there's something more thorough in the works! If you would prefer, I can pull the JDK 22 bump into my PR and do an overall update sources there | 17:08:10 |
Philip Taron (UTC-8) | Let's do that | 17:08:23 |
@infinidoge:matrix.org | (Currently working on bumping Semeru which is why I ask) | 17:08:25 |
@infinidoge:matrix.org | Would pretty much just cherrypick your commit but exclude the sources update, then update sources all at once | 17:08:47 |
Philip Taron (UTC-8) | semeru has 18, 19, 20, 21, and 22 available | 17:09:10 |
Philip Taron (UTC-8) | and also has the 1-tuple bug in the generate-sources | 17:09:23 |
@infinidoge:matrix.org | I think I'll just add 21 and 22, since 18, 19, and 20 are EOL | 17:09:35 |
@infinidoge:matrix.org | Though I don't see 22 on the website, so I'll double check its availability | 17:10:03 |
Philip Taron (UTC-8) | I saw it in https://github.com/ibmruntimes/semeru22-binaries | 17:10:26 |
@infinidoge:matrix.org | It's always funny to me to see a GitHub repo with just a readme and version tags | 17:11:15 |
@infinidoge:matrix.org | Whoops, branch deleted before I could cherry-pick | 17:19:22 |