| 17 Sep 2025 |
 msgilligan | I fixed the nixpkgs-vet error about new top-level package using pkgs.callPackage in the zulu25 PR: https://github.com/NixOS/nixpkgs/pull/443517/commits/f65e6c648d89794fc801d95280355dcca779f990 | 19:54:01 |
| msgilligan | This is my first time refactoring usage of callPackage so I'm not sure I did it right, but it looks reasonably clean and seems to work, so please take a look and let me know if I got it right. | 19:56:19 |
 emily | you can inherit ({ zulu8 = callPackage …; … }) zulu8 …; | 19:56:35 |
| emily | (yes it's silly) | 19:56:37 |
| msgilligan | in the new default.nix? That seems more verbose, is there an advantage to doing it that way? | 19:58:47 |
| emily | no, in all-packages.nix | 20:00:53 |
| emily | it's just the officially-sanctioned hack for when there is an existing multi-version package outside of by-name | 20:01:04 |
| msgilligan | Oh, I see other instances of this patter in all-packages.nix. I'll fix it! | 20:02:59 |
| msgilligan | So like this:
inherit (callPackage ../development/compilers/zulu { })
zulu8
zulu11
zulu17
zulu21
zulu23
zulu24
zulu25
;
zulu = zulu21;
?
| 20:10:10 |
| emily | what i mean is you don't need the default.nix at all | 20:13:25 |
| emily | https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/README.md#recommendation-for-new-packages-with-multiple-versions | 20:14:02 |
| emily | you can literally just inherit ({ … }) …; in all-packages.nix | 20:14:12 |
| emily | it is silly, but it is the sanctioned workaround | 20:14:23 |
| emily | the "nice" solution is to do a version-generic package in by-name like I did for OpenJFX but it's more work | 20:14:38 |
| msgilligan | OK, here we go:
https://github.com/NixOS/nixpkgs/pull/443517/commits/a0234222be9339562870af5e02c1c0adc9529ade | 20:27:52 |
| msgilligan | I this PR? https://github.com/NixOS/nixpkgs/pull/350736/ | 20:32:40 |
| msgilligan | * In this PR? https://github.com/NixOS/nixpkgs/pull/350736/ | 20:32:53 |
| msgilligan | Redacted or Malformed Event | 20:33:43 |
| emily | yeah | 20:35:18 |
| msgilligan | (I need to get in the habit of running nix fmt before pushing...) | 20:41:28 |
| msgilligan | * I had a minor fmt error which is now fixed. (I need to get in the habit of running nix fmt before pushing...) | 20:41:53 |
| msgilligan | * OK, here we go:
https://github.com/NixOS/nixpkgs/pull/443517/commits/a27db0ff606bac12a4bbba07fc291a04eef3c7f0 | 20:42:25 |
 Infinidoge 🏳️⚧️ | I wish things weren't all being corralled into by-name, things that make sets of packages like Java don't really make sense to be shoved into that format | 21:37:40 |
| Infinidoge 🏳️⚧️ | Eh, besides the point | 21:37:47 |
| msgilligan | OK, so the zulu25 PR is passing all tests and is ready-for-review. I a have a follow-on PR that makes zulu25 the default zulu. And we need to remove zulu23 and zulu24 but I think we need to remove OpenJDK 23 first: https://github.com/NixOS/nixpkgs/pull/403247/ | 21:37:49 |
| Infinidoge 🏳️⚧️ | Sorry for not helping much, mix of busy and trying to recover from Events:tm:
If there is anything that really needs a review ping me, but don't expect much on the issues for a little while | 21:38:47 |
| msgilligan | zulu25 has one approval now, but still needs someone to merge it. | 21:43:00 |
| msgilligan | I've also updated the Java 25 Support Tracking Issue and added a comment on
why we prioritize 5 JDK distros. | 22:10:11 |
| msgilligan | I said "we" based upon my understanding of the communities priorities and I invite comments if that list or the rationale for it should be changed. | 22:26:36 |
| msgilligan | * I said "we" based upon my understanding of the community's priorities and I invite comments if that list or the rationale for it should be changed. | 22:26:50 |
