| 22 Sep 2025 |
 msgilligan | I'm working on a PR 🤣 | 18:36:59 |
| msgilligan | Like the scorpion and the frog, but in a good way... | 18:37:09 |
| msgilligan | I think the test just needs to use Paths.get(input).normalize() | 18:37:54 |
| msgilligan | Function<String, String> normalize = s ->Paths.get(s).normalize().toString();
| 18:42:29 |
| msgilligan | * Function<String, String> normalize = s ->Paths.get(s).normalize().toString();
| 18:42:36 |
 Benedikt Ritter (britter) | Yeah. When you propose that as a PR there's a helper function in nixpkgs for pulling it as a patch. We can add that to my PR so it will build on macOS. | 18:47:10 |
| msgilligan | Oh cool! | 18:47:25 |
| msgilligan | Now I'm feeling less scorpion-like... | 18:47:42 |
| Benedikt Ritter (britter) | I think it's called fetchPatch or something? An you can pass the URL to a github PR or there was a special URL for each PR that would just return the diff. | 18:56:02 |
| Benedikt Ritter (britter) | If you give me the PR URL I can update my PR and you can try again. | 18:56:18 |
| msgilligan | Fix for broken unit test on macOS in Stirling-PDF:
https://github.com/Stirling-Tools/Stirling-PDF/pull/4477 | 19:09:51 |
| msgilligan | Posted directly in the room | 19:10:08 |
| msgilligan | I'm looking forwarding to seeing this for the first time! | 19:23:18 |
| msgilligan | I guess you'll leave the tests on so all I have to do is nixpkgs-review pr 445032, right? | 19:24:28 |
| Benedikt Ritter (britter) | I updated the PR to pull the changed from your PR. Can you try again? | 19:26:59 |
| msgilligan | Running... | 19:29:07 |
| msgilligan | nixpkgs-review passes on both aarch64-darwin and aarch64-linux. The PR is also passing upstream CI:
https://github.com/Stirling-Tools/Stirling-PDF/pull/4477/checks | 19:42:50 |
| Benedikt Ritter (britter) | Thanks! | 19:44:06 |
| msgilligan | You're welcome! | 19:44:25 |
| msgilligan | I am benefitting so much from the Nix Gradle work you have done, that the balance is still heavily in your favor! | 19:45:32 |
| msgilligan | Merged upstream. | 19:57:49 |
|  @ihar.hrachyshka:matrix.org joined the room. | 23:35:23 |
| 23 Sep 2025 |
|  a-kenji changed their display name from a-kenji to kenji. | 10:38:30 |
| 24 Sep 2025 |
| msgilligan | I haven't had a chance to follow-up on this comment, but it looks promising: https://github.com/NixOS/nixpkgs/issues/412283#issuecomment-3325887652 | 04:50:15 |
| msgilligan |
With this workaround, JDK24 compiles correctly with JFX support.
| 04:50:36 |
 emily | looks like shipping the jlink thing would also fix it going by the linked release notes | 05:01:34 |
| msgilligan | I'm thinking we should encourage applications to pull in their JavaFX jars/modules separately from the JDK when possible (which I believe should be almost always) I haven't actually tested this yet, but hope to soon. JavaFX was designed to be independent of the JDK (though maybe now for a smaller range of versions) and having a little more flexibility here should make upgrades less painful. | 05:09:47 |
| emily | yes, please :) | 15:02:35 |
| emily | I hate the JFX entangled into the JDK build thing, as you know | 15:02:46 |
| emily | I think that one jlink PR to get rid of that looked pretty good in principle, I forget if I had any complaints about it | 15:03:10 |
