| 19 Sep 2025 |
msgilligan | But we have a bunch of Temurin updates to the existing versions that should be made, I think. I ran the update python script and generated this PR: https://github.com/NixOS/nixpkgs/pull/443891 | 14:59:04 |
msgilligan | Should that be split into multiple PRs (one for each version bump maybe) and targeted to staging? | 15:00:01 |
msgilligan | * But we have a bunch of Temurin updates to the existing versions that should be made, I think. I ran the update python script and generated this (massive-rebuild-triggering) PR: https://github.com/NixOS/nixpkgs/pull/443891 | 15:00:47 |
msgilligan | https://adoptium.net/temurin/releases/?version=25&os=any&arch=any | 15:04:04 |
msgilligan | The website is updated but nothing is actually there except alpine x64 | 15:04:54 |
msgilligan | Here's a status page:
https://github.com/adoptium/temurin/issues/96 | 15:07:34 |
emily | one PR to staging is fine | 15:13:44 |
emily | we're about to start a cycle in the next couple days | 15:13:47 |
emily | any other mass rebuild Java PRs to land? | 15:13:59 |
msgilligan | What is a "cycle"? | 15:14:36 |
Alyssa Ross | https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#staging | 15:15:23 |
emily | https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#staging | 15:15:27 |
emily | ha | 15:15:27 |
msgilligan | Read the fine manual 🤣 | 15:15:49 |
emily | staging-next-25.05 is about to merge to release-25.05, so we will soon have staging-next cut from staging and start to build | 15:15:53 |
msgilligan | OK PR 443891 is rebased to staging. (I rebased and force-pushed before switching the target branch with the GitHub PR UI and that confused some of the tests. But I force-pushed a second time and that seems to have reset everything) | 15:46:31 |
emily | you usually don't need to rebase | 15:46:43 |
emily | master is merged into staging every 6 hours | 15:46:47 |
emily | so any master commit that is not more recent than that is already on staging | 15:46:57 |
emily | have you tested the Temurin bumps work for the OpenJDK bootstrap? | 15:47:18 |
emily | probably fine to optimistically merge since it's unlikely they broke | 15:47:30 |
msgilligan | I haven't done any local testing. I usually run Nixpkgs review, but for this PR it would probably tie up my machine for days. | 15:50:49 |
msgilligan | How do you test the OpenJDK bootstrap? | 15:51:28 |
msgilligan | Currently running nix build .#temurin-bin .#temurin-bin-23 .#temurin-bin-24 | 15:52:44 |
msgilligan | * Currently running nix build .#temurin-bin .#temurin-bin-23 .#temurin-bin-24 (which I may have done previously) | 15:54:08 |
msgilligan | * Currently running nix build .#temurin-bin .#temurin-bin-23 .#temurin-bin-24 (which I may have done previously. i.e. when the PR was targeting master) | 16:11:38 |
Tomodachi94 (they/them) | And if you're a committer, you can manually trigger that merge too if you're blocked by needing a change that is newer than 6 hours (if you're not a committer, I'm willing to) | 16:12:54 |
emily | just build openjdk{8,11,17,21,…} | 16:26:12 |
emily | since those use the Temurin binaries | 16:26:18 |
emily | I suggest targeting it back to master | 16:26:32 |