| 21 Aug 2025 |
 emily | check out release-25.05 and apply the commit on top | 20:44:58 |
| emily | (e.g. via curl ….patch | git apply or by fancy gh command) | 20:45:12 |
| emily | (or fetching the PR branch / pulls/N/head commit and git cherry-picking that) | 20:45:26 |
| emily | and then build jdk | 20:45:28 |
 msgilligan | OK, I'll do it after I change location. | 20:45:51 |
 PROgrm_JARvis | Running nixpkgs-review on it just now (x86_64-linux) | 20:47:13 |
| emily | that will never terminate | 20:47:36 |
| emily | it'll build thousands of packages | 20:47:39 |
| emily | only the actual jdk package can reasonably be tested / needs testing | 20:47:52 |
| PROgrm_JARvis | 
Download image.png | 20:48:09 |
| PROgrm_JARvis | Yup, tested build on x86_64-linux -- it works:
$ nix build .#jdk21_headless
$ ./result/bin/java --version
openjdk 21.0.8 2025-07-15
OpenJDK Runtime Environment (build 21.0.8+9-nixos)
OpenJDK 64-Bit Server VM (build 21.0.8+9-nixos, mixed mode, sharing)
| 21:16:12 |
| emily | thanks | 21:16:21 |
| emily | merged it | 21:16:35 |
| PROgrm_JARvis | Thank you! | 21:17:11 |
| msgilligan | nix build .#jdk on aarch64-darwin builds Zulu 21.0.4+7-LTS | 22:30:49 |
| emily | yeah, the package isn't used on Darwin. (sadly.) | 22:31:51 |
| msgilligan | I "knew" that, but forgot momentarily and was reminded when I did the build. | 22:32:42 |
| msgilligan | Building building openjdk-21.0.8+9 on aarch64-linux (on Orion O6) | 22:42:44 |
| msgilligan | Making PR for Zulu 21.0.8... | 22:50:29 |
| msgilligan | * Making PR for Zulu 21.0.8:
https://github.com/NixOS/nixpkgs/pull/435705 | 23:09:02 |
| msgilligan | * Building building openjdk-21.0.8+9 on aarch64-linux (on Orion O6)
Looks good after quick tests: ./result/bin/java -version and ./result/bin/javac -version
| 23:12:34 |
| 22 Aug 2025 |
| msgilligan | I changed the above PR to target staging | 17:44:16 |
| 24 Aug 2025 |
|  D. Ebling joined the room. | 22:19:21 |
| 27 Aug 2025 |
 vog | What is needed to make this already-reviewed PR finally merged? Is a second approval needed?
https://github.com/NixOS/nixpkgs/pull/427538 | 07:58:38 |
| D. Ebling changed their display name from Denilson Ebling to D. Ebling. | 20:49:44 |
| 28 Aug 2025 |
|  Pol left the room. | 08:14:02 |
| 29 Aug 2025 |
|  luna-null left the room. | 02:40:23 |
| 30 Aug 2025 |
 Benedikt Ritter (britter) | In reply to @vog:matrix.org
What is needed to make this already-reviewed PR finally merged? Is a second approval needed?
https://github.com/NixOS/nixpkgs/pull/427538 You can post it to Nixpkgs Review Requests matrix channel asking for somebody to merge it. | 16:06:23 |
| vog | Redacted or Malformed Event | 16:07:09 |
| vog | Ok, Thanks! | 16:07:44 |
