!aRKdLCkUeIFjRPZuJT:nixos.org

NixOS JVM

129 Members
28 Servers

Load older messages


SenderMessageTime
22 Nov 2024
@tomodachi94:matrix.orgTomodachi94 (they/them)share/ant is the convention used by Debian and possibly others17:04:41
@tomodachi94:matrix.orgTomodachi94 (they/them)...and tons more too, see PR description: https://github.com/NixOS/nixpkgs/pull/35820417:31:00
@tomodachi94:matrix.orgTomodachi94 (they/them)* ...and tons of other distros too, see PR description: https://github.com/NixOS/nixpkgs/pull/35820417:36:09
@numinit:matrix.orgMorgan (@numinit) joined the room.17:50:01
@tomodachi94:matrix.orgTomodachi94 (they/them)Welcome :)18:06:14
@numinit:matrix.orgMorgan (@numinit) howdy :-) 18:12:53
@numinit:matrix.orgMorgan (@numinit)gradle2nix kind of rules my day job in certain ways, noticed that this exists and figured I'd poke my head in 😛18:15:46
23 Nov 2024
@tomodachi94:matrix.orgTomodachi94 (they/them) I'm wondering if we should make a temporary branch in Nixpkgs for all of my Ant refactors devel-ant, PRing from my fork into the branch. From there, merge devel-ant' into staging`, then delete it once it's done 00:51:10
@tomodachi94:matrix.orgTomodachi94 (they/them) I'm wondering if we should make a temporary branch in Nixpkgs for all of my Ant refactors devel-ant, PRing from my fork into the branch. From there, merge devel-ant into staging, then delete it once it's done 00:52:54
@tomodachi94:matrix.orgTomodachi94 (they/them) I'm wondering if we should make a temporary branch in Nixpkgs for all of my Ant refactors devel-ant, PRing from my fork into the branch. From there, merge devel-ant into staging, then delete it once it's merged there 00:53:08
@tomodachi94:matrix.orgTomodachi94 (they/them)It would save rebuilds and ensure the refactors all hit at the same time, but I'm not sure it's standard00:53:39
@emilazy:matrix.orgemilyhow many commits are we talking here in expectation?00:55:34
@emilazy:matrix.orgemilywe did a separate branch to PR into for https://github.com/NixOS/nixpkgs/pull/354107, though that was a ~2-person collaborative project that took a couple weeks00:56:09
@emilazy:matrix.orgemily rebuilds aren't an issue – staging isn't built 00:56:19
@emilazy:matrix.orgemily (that's why we have staging-next) 00:56:24
@tomodachi94:matrix.orgTomodachi94 (they/them)
In reply to@emilazy:matrix.org
how many commits are we talking here in expectation?
Unsure. That depends on how many dependencies on ant-contrib there are
01:06:26
@emilazy:matrix.orgemilymy intuition would be that you can get away with just having a PR01:10:19
@emilazy:matrix.orgemilybut I could be wrong :)01:10:22
@emilazy:matrix.orgemilyrebuilds aren't worth worrying about anyway01:10:27
@emilazy:matrix.orgemily have you seen the CONTRIBUTING.md section about the stagling flow? 01:10:37
@emilazy:matrix.orgemily we periodically cut staging-next from staging and that's what gets built on Hydra 01:10:55
@emilazy:matrix.orgemily otherwise everything just queues up there waiting for the next -next 01:11:04
@tomodachi94:matrix.orgTomodachi94 (they/them)I'm mostly worried about the mandatory 1-week waiting period for modifications to packages (there are a few maintainers who don't appear to be responsive)01:13:41
@tomodachi94:matrix.orgTomodachi94 (they/them)* I'm mostly worried about the mandatory 1-week waiting period for modifications to packages (there are at least a few maintainers who don't appear to be responsive)01:13:51
@tomodachi94:matrix.orgTomodachi94 (they/them)And also worried about reviewer fatigue with one massive PR (and, since it would be a pretty big PR, keeping it rebased could become difficult if it sits for a while)01:15:33
@emilazy:matrix.orgemilythat period is made up01:15:40
@emilazy:matrix.orgemilyI don't think I've ever seen it followed other than for like "this package has an active maintainer and this is a significant breaking change"01:16:00
@emilazy:matrix.orgemily if we did staging like that every cycle would take two months 01:16:15
@emilazy:matrix.orgemily FWIW I think you can also just do separate PRs directly into staging? 01:16:38
@emilazy:matrix.orgemilyit's okay to break stuff and then fix it as long as you have a plan for fixing it01:16:45

Show newer messages


Back to Room ListRoom Version: 6