| 12 Nov 2024 |
 Tomodachi94 (they/them) | Yep it is. I tried appendToVar postPatchPhases patchMavenPomHook and then appendToVar postPatchHooks patchMavenPomHook to no avail, only appendToVar preConfigurePhases patchMavenPomHook worked | 01:28:08 |
 emily | ah | 01:29:19 |
| 13 Nov 2024 |
|  Inayet joined the room. | 22:15:08 |
| 14 Nov 2024 |
| Tomodachi94 (they/them) | https://github.com/NixOS/nixpkgs/pull/256354 | 18:10:12 |
| Tomodachi94 (they/them) | Another day, another new JDK PR | 18:11:37 |
| Tomodachi94 (they/them) | * Another day, another new JDK addition | 18:11:47 |
| emily | NO!!!!! | 18:15:46 |
| emily | well actually this is the fancy Azul stuff | 18:15:57 |
| emily | so I guess it might be okay | 18:15:59 |
| emily | replied | 18:21:34 |
| emily | I think it's somewhat of a licensing footgun as it is. I suspect terrorjack may have been (unwittingly?) violating the terms already… | 18:22:00 |
| emily | no inherent objection beyond that though | 18:22:20 |
 @terrorjack:matrix.terrorjack.com | feel free to close it; i also suspect it somehow doesn't follow the convention in nixpkgs that require you to manually add the blob to nix store | 18:23:01 |
| emily | yeah I posted that maybe we should requireFile instead | 18:23:35 |
| emily | the no!! was a joke though :) | 18:23:39 |
| emily | just because I've been trying to remove useless JDKs lately | 18:23:47 |
| @terrorjack:matrix.terrorjack.com | and not sure that indirection free us from concern of getting a lawyer letter anyway | 18:23:57 |
| emily | I think requireFile is fine in principle | 18:35:34 |
| emily | we're allowed to have scripts to use packages that you need a licence for, I think | 18:35:45 |
| emily | it's just on you to follow the licence | 18:35:48 |
| emily | but if you don't want to maintain it then I'm fine just closing it :) | 18:36:00 |
| @terrorjack:matrix.terrorjack.com | closed with comment, thx for the review | 19:35:24 |
| 16 Nov 2024 |
| Tomodachi94 (they/them) | shakes fist at sky ant-contrib used to be a separate package... until a commit 10 years ago by edolstra | 05:03:06 |
| Tomodachi94 (they/them) | There are a lot of weird things with the Ant package | 05:03:21 |
| Tomodachi94 (they/them) | In reply to@tomodachi94:matrix.org
shakes fist at sky ant-contrib used to be a separate package... until a commit 10 years ago by edolstra It was the same commit that introduced the custom Ant wrapper | 05:06:21 |
| emily | 😆 | 05:06:33 |
| emily | "oh, it's from a decade-old commit by edolstra" is the free space in Nix bingo | 05:06:49 |
| Tomodachi94 (they/them) | In reply to@tomodachi94:matrix.org
It was the same commit that introduced the custom Ant wrapper Wait kinda but not really. It was built in a separate derivation, then symlinked into the ant derivation... 16 years ago, in a commit by Tobias Hanmerschmidt, until aforementioned edolstra refactor | 05:12:03 |
| Tomodachi94 (they/them) | (The separate derivation just shoved it into $out directly) | 05:12:41 |
| Tomodachi94 (they/them) | * (The separate derivation just shoved it into $out directly, from what I can see) | 05:12:50 |
