25 Nov 2024 |
emily | anyway, it's not that bad, since bisection is O(log n) | 14:07:57 |
FliegendeWurst (@GPN23) | oh good news! | 14:09:17 |
FliegendeWurst (@GPN23) | jdk8.override { stdenv = gcc13Stdenv; zip = zip.override { stdenv = gcc13Stdenv; }; } builds | 14:09:19 |
FliegendeWurst (@GPN23) | (I bet you could remove the first override) | 14:09:30 |
emily | oh wonderful | 14:16:44 |
emily | it's probably exposing some UB | 14:16:51 |
emily | check Arch/Fedora/Gentoo/… for patches | 14:17:09 |
chayleaf | In reply to @tomodachi94:matrix.org Wondering if we should drop the programs.java NixOS module, since it's impure and only has two in-tree consumers (packages should make a wrapper that calls jdk /jre , developers should be using devShells) it doesn't seem completely useless as it also sets JAVA_HOME (adding Java to environment.systemPackages does seem like something you'd want to do sometimes), but imo if we were to remove it it's better to start by deprecating or completely removing the binfmt part and seeing if anyone complains, as it's the only non-trivial part of the module | 16:31:36 |
Tomodachi94 (they/them) | In reply to@tomodachi94:matrix.org More information about my plans to rip out ant-contrib from the main ant package: https://github.com/NixOS/nixpkgs/issues/357758 ....all of these packages still build if I rip out ant-contrib, even though some of them definitely have targets that use its tasks | 19:08:00 |
Tomodachi94 (they/them) | Source for the latter: rg -Lz --glob "build.xml" '<(foreach|antcallback|antfetch|assert|foreach|for|if|outoutdate|runtarget|switch|throw|timestampselector|trycatch|post|stopwatch|osfamily|shellscript|math|propertycopy|propertyselector|pathtofileset|propertyregex|sortlist|urlencode|var|forget|limit|compilewithwalls|antclipse|inifile|verifydesign)\b' | less | 19:09:00 |
Tomodachi94 (they/them) | Source for the latter: rg -Lz --glob "build.xml" '<(foreach|antcallback|antfetch|assert|foreach|for|if|outoutdate|runtarget|switch|throw|timestampselector|trycatch|post|stopwatch|osfamily|shellscript|math|propertycopy|propertyselector|pathtofileset|propertyregex|sortlist|urlencode|var|forget|limit|compilewithwalls|antclipse|inifile|verifydesign)\b' | less over all src s of Ant dependents | 19:09:24 |
Philip Taron (UTC-8) | In reply to @fliegendewurst:matrix.org yes https://github.com/NixOS/nixpkgs/pull/355844 not merged I merged | 19:18:38 |
Philip Taron (UTC-8) | In reply to @fliegendewurst:matrix.org yes https://github.com/NixOS/nixpkgs/pull/355844 not merged * I merged after griping a bit | 19:18:46 |
Tomodachi94 (they/them) | In reply to@tomodachi94:matrix.org Source for the latter: rg -Lz --glob "build.xml" '<(foreach|antcallback|antfetch|assert|foreach|for|if|outoutdate|runtarget|switch|throw|timestampselector|trycatch|post|stopwatch|osfamily|shellscript|math|propertycopy|propertyselector|pathtofileset|propertyregex|sortlist|urlencode|var|forget|limit|compilewithwalls|antclipse|inifile|verifydesign)\b' | less over all src s of Ant dependents I'm going to queue a nixpkgs-review run and see if anything new breaks 🙃 then we can just get rid of it entirely (without repackaging it), since it's had no releases since 2006 | 19:48:22 |
Tomodachi94 (they/them) | Source for the latter: rg -Lz --glob "build.xml" '<(foreach|antcallback|antfetch|assert|foreach|for|if|outoutdate|runtarget|switch|throw|timestampselector|trycatch|post|stopwatch|osfamily|shellscript|math|propertycopy|propertyselector|pathtofileset|propertyregex|sortlist|urlencode|var|forget|limit|compilewithwalls|antclipse|inifile|verifydesign)\b' | less over all src s of Ant dependents (all of those are tasks provided exclusively by ant-contrib) | 20:32:47 |
Tomodachi94 (they/them) | In reply to@tomodachi94:matrix.org Source for the latter: rg -Lz --glob "build.xml" '<(foreach|antcallback|antfetch|assert|foreach|for|if|outoutdate|runtarget|switch|throw|timestampselector|trycatch|post|stopwatch|osfamily|shellscript|math|propertycopy|propertyselector|pathtofileset|propertyregex|sortlist|urlencode|var|forget|limit|compilewithwalls|antclipse|inifile|verifydesign)\b' | less over all src s of Ant dependents (all of those are tasks provided exclusively by ant-contrib) It's also possible (and likely) that these packages use Ivy and ant-contrib gets downloaded and used that way | 20:34:05 |
Tomodachi94 (they/them) | * It's also possible (and likely) that these packages use Ivy, and ant-contrib gets downloaded and used that way | 20:34:15 |
Tomodachi94 (they/them) | (Aside: Some of the tasks provided by -contrib seem like they should be included in core Ant) | 20:34:48 |
Tomodachi94 (they/them) | * (Aside: Some of the tasks provided by ant-contrib seem like they should be included in core Ant) | 20:35:00 |
Tomodachi94 (they/them) | 188/198(???) built successfully, and the only failures so far are known broken packages | 21:33:36 |
Tomodachi94 (they/them) | In reply to@tomodachi94:matrix.org I'm going to queue a nixpkgs-review run and see if anything new breaks 🙃 then we can just get rid of it entirely (without repackaging it), since it's had no releases since 2006 No failures when just removing ant-contrib in its entirety | 21:55:58 |
Tomodachi94 (they/them) | * No failures when just removing ant-contrib in its entirety 🙌 | 21:56:16 |
Tomodachi94 (they/them) | https://github.com/NixOS/nixpkgs/pull/359137 | 22:30:46 |
Tomodachi94 (they/them) | Ghosts begone 👻 | 22:44:19 |
Tomodachi94 (they/them) | * 2006 ghosts begone 👻 | 22:44:39 |
Tomodachi94 (they/them) | I wonder if the person who added this way back when would respond if I requested a review from them | 22:57:55 |
Tomodachi94 (they/them) | * I wonder if the person who added this way back when would respond if I requested a review from them (Tobias Hanmerschmidt) | 22:58:15 |
Tomodachi94 (they/them) | (Probably not, he isn't in the NixOS org and his Nixpkgs fork is gone) | 23:00:05 |
Tomodachi94 (they/them) | * I wonder if the person who added this way back when would respond if I requested a review from them (Tobias Hammerschmidt) | 23:00:44 |
Tomodachi94 (they/them) | (And might have never had either, ant-contrib was introduced into Ant when SVN was still in use) | 23:03:28 |