!aRKdLCkUeIFjRPZuJT:nixos.org

NixOS JVM

142 Members
32 Servers

Load older messages


SenderMessageTime
2 Jun 2026
@britter:yatrix.orgBenedikt Ritter (britter)I've also updated the maven_4 PR to use jdk25_headless.09:54:26
3 Jun 2026
@britter:yatrix.orgBenedikt Ritter (britter) @pyrox:pyrox.dev is this something you could review? 11:44:54
@pyrox:pyrox.devdish [Fox/It/She]reviewed16:09:15
4 Jun 2026
@callmeecho:matrix.orgEcho changed their profile picture.04:23:43
@msgilligan:matrix.orgmsgilligan I took a first look. Overall it looks awesome. I have a few minor requests and I really should do a more thorough second review. I'm currently trying to run nixpkgs-review on it. 06:51:04
@msgilligan:matrix.orgmsgilligan * I took a first look. Overall it looks awesome. I have a few minor requests and I really should do a more thorough second review. I'm currently trying to run ran nixpkgs-review on it. (Update ❌ 2 failures ✅ 74 packages built) 07:18:35
@britter:yatrix.orgBenedikt Ritter (britter)I'll have a look at the failures later today. I also want to get the community builder connectes to my machine so I can more easily run these massive rebuilds.09:05:50
@britter:yatrix.orgBenedikt Ritter (britter)Didn't get around to doing this... sorry!20:02:44
@britter:yatrix.orgBenedikt Ritter (britter)Just a heads up, I'm traveling the next two weeks and am not sure whether I will take my computer. So my maven PRs will have to wait until I'm back.20:03:29
7 Jun 2026
@britter:yatrix.orgBenedikt Ritter (britter)Can somebody merge this for me? It's just another rec -> finalAttrs PR: https://github.com/NixOS/nixpkgs/pull/52714907:05:35
@msgilligan:matrix.orgmsgilligan Trying @NixOS/nixpkgs-merge-bot merge... 07:15:22
@infinidoge:inx.moeInfinidoge 🏳️‍⚧️Hey look fancy button07:21:50
@infinidoge:inx.moeInfinidoge 🏳️‍⚧️Should auto merge when checks pass07:22:03
@msgilligan:matrix.orgmsgilliganSometimes it works (and when it doesn’t it gives a checklist explaining why)16:11:14
18 Jun 2026
@britter:yatrix.orgBenedikt Ritter (britter)I'm back from vacation and will pick up the maven PR again that I was working on. maven_4 has landed in the meantime.05:37:41
@whispers:catgirl.cloudwhispers [& it/fae] changed their display name from whispers [& it/fae] to meow meow.18:46:32
@whispers:catgirl.cloudwhispers [& it/fae] changed their display name from meow meow to whispers [& it/fae].19:12:08
@britter:yatrix.orgBenedikt Ritter (britter)

@pyrox:pyrox.dev I've updated the PR that introduces the default plugins repo. I've addressed review feedback and added two commits that handle unrelated package build failures. Not sure if that should be separate PRs. I wanted a state where nixpkgs-review passes with out having to wait for other PRs to be merged first.

I've also rebased onto main and ran into an issue with the new maven_4 package that was merged recently: unfortunately they changed completely how default plugin versions are handled inside maven. Previously it was some xml files, which made it easy to extract this data. Now it' constants in Java code which are constructed by concatination of other constants. So there's no easy grep in the java sources solution for maven_4.
I didnt want to blow the scope of the PR, so I decided to add some logic that make maven_4 behave like maven_3 did before: essentially package dependency FOD hashes need to be updated when maven_4 package is updated. I want to address this in a follow up PR.

Link: https://github.com/NixOS/nixpkgs/pull/527061

20:23:00
19 Jun 2026
@britter:yatrix.orgBenedikt Ritter (britter)Why does changing maven still trigger a rebuild of authentik which is a python application?09:50:13
@marie:marie.cologneMarieit shouldn't, at least nix why-depends says it doesn't depend on it09:56:12
@britter:yatrix.orgBenedikt Ritter (britter) @msgilligan:matrix.org could you give the default plugins PR another review and also run nixpkgs-review on aarch? 17:33:38
20 Jun 2026
@britter:yatrix.orgBenedikt Ritter (britter)

Folks, https://github.com/NixOS/nixpkgs/pull/527061 is ready to be integrated from my PoV. I fixed the two failing packages and I tested the whole update flow end to end:

  • run update script on maven updates maven's src coords as well as the default plugins repo hash.
  • rebuilding a downstream package works without recalculating that package's mvnHash.

I'd relly like to get that in so we can focus on the maven version update that was blocked because of many downstream packages breaking with mvnHash missmatches.

07:01:23
24 Jun 2026
@britter:yatrix.orgBenedikt Ritter (britter)

Just a quick update on that one 👆 unfortunately (or luckily?) @fliegendewurst:matrix.org pointed out, that the approach I implemented doesn't work. There is a lot of complexity in capturing the project dependencies and separating it from the implicit plugin dependencies. In particular a plugin that is pulled in implicitly via default plugin versions might have a dependency on google guava. So guava needs to be part of the default plugins FOD. But there may be a project thay where that guava version might also be reachable as a direct project dependency. In that case it needs to be part of the project's dependency FOD as well.
Then there is also the complexity of implicit dependencies resolved at runtime that are project dependent. A good example for this is maven-surefire-plugin: it resolves test framework provider jars based on which test framework is on the classpath. The version of the provider depends on the plugin version and the plugin version may not be explicitly defined, so ends up being maven version dependent.
I realize this is a lot to digest, so I might as well write a blog post... 🤔

So anyway, I'm not ready yet to give up on @msgilligan:matrix.org idea, because I think it would be great to have it... So yesterday I started vibe coding a maven extension that writes two dependency manifest files: one for the project dependencies and one for the implicit dependencies as a machine readable json file.
This can be injected into the build, when we capture project dependencies. In order to capture all possible implicit dependencies, I will set up a probe project in nixpkgs, so for each maven release we can run a command to generate the complete closure of implicit dependencies.
Heres the code: https://github.com/britter/nixpkgs-maven-extension

I want to try and see if I can come up with an implementation in nixpkgs thay correctly separates project dependencies from implicit dependencies...

Will keep you posted.

06:13:08
15 Jun 2021
@grahamc:nixos.org@grahamc:nixos.org set the history visibility to "world_readable".13:58:25
@grahamc:nixos.org@grahamc:nixos.org changed the room name to "" from "".13:58:25
@grahamc:nixos.org@grahamc:nixos.org invited @fzakaria:matrix.orgfzakaria (Old).13:58:33
@server_stats:nordgedanken.devServer Stats Discoverer (traveler bot) joined the room.14:03:43
@voyager:t2bot.ioMatrix Traveler (bot) joined the room.14:15:47
@joerg:bethselamin.deMic92 joined the room.14:23:40
@charlotte:vanpetegem.mechvp joined the room.14:23:42

Show newer messages


Back to Room ListRoom Version: 6