| 25 Nov 2022 |
K900 | Also filed an issue on our side: https://github.com/nix-community/NixOS-WSL/issues/171 | 18:22:41 |
K900 | Oh no I found another bug | 18:23:57 |
K900 | The installer does not work AT ALL with native-systemd | 18:24:24 |
K900 | Because we're propagating /etc/wsl.conf into it | 18:25:10 |
K900 | And there's obviously no systemd in the installer | 18:25:17 |
Arson Copperflame | I know, that's why I skipped making tests for it for now | 18:25:17 |
Arson Copperflame | We need to include /etc/wsl.conf for the initial boot to work correctly | 18:25:36 |
K900 | Maybe it should be a different wsl.conf then | 18:25:55 |
Arson Copperflame | I'd suggest we run the installer script through the systemd wrapper and include that in the installer tarball | 18:25:57 |
K900 | That would need us to stick the entire systemd closure into the initial tarball | 18:26:22 |
K900 | Which is oof | 18:26:25 |
K900 | What's the smallest wsl.conf we can have that still works? | 18:26:47 |
K900 | Maybe we should just have the installer read -p at the end and die horribly | 18:27:10 |
K900 | And then make you restart the VM | 18:27:16 |
Arson Copperflame | We could make a second binary that execs the systemd wrapper once it's unpacked | 18:28:34 |
K900 | eww | 18:28:44 |
Arson Copperflame | Or can we somehow explicitly remove systemd from the wrappers closure? | 18:28:58 |
K900 | That's a whole other use case | 18:29:07 |
K900 | Like, that's a whole other scenario to test | 18:29:25 |
K900 | That doesn't look normal at all | 18:29:29 |
K900 | Maybe we can just ignore it until upstream fixes their shit | 18:29:45 |
K900 | And if you want native systemd, you just need to rebuild after | 18:29:55 |
Arson Copperflame | I think that's the best option for now. I might look into fixing the installer later if I have time | 18:31:17 |
K900 | I just want upstream to talk to non-Ubuntu distros | 18:31:44 |
K900 | Anyway tests are good on #170 and almost good on #169 | 18:34:55 |
K900 | (nice) | 18:34:58 |
K900 | Green on both now | 18:35:10 |
Sandro 🐧 | K900: didn't @mic92 give you permissions on nixos-wsl? | 18:46:21 |
K900 | Nope | 18:46:26 |
Sandro 🐧 | In reply to @nzbr:nzbr.de Merged! Please rebase/merge main into your PRs K900 Sandro 🐧 psvo doing later if I don't forget | 18:47:03 |