| 1 Feb 2023 |
 Sandro 🐧 | Same, just was thinking if this would make things easier for us | 10:02:07 |
| Sandro 🐧 | I am not sure if we should do the updater in the distro launcher | 10:17:38 |
| Sandro 🐧 | IMO it probably opens a new area of problems | 10:17:56 |
 Arson Copperflame | It's a script at a fixed location inside the tarball (/nix/wsl-installer/updater.sh currently), that the launcher runs. It's possible to run the updater without the launcher and the release notes will describe both options | 10:20:11 |
| Arson Copperflame | 
Download image.png | 10:42:11 |
| Arson Copperflame | The magic 22.11 progress-bar just turned green. Now is your chance to come up with possible release names
(or emergency blockers that should be in the release) | 10:43:03 |
| Arson Copperflame | * The magic 22.11 progress-bar just turned green. Now is your chance to come up with possible release names
(or emergency fixes that should be in the release) | 10:43:19 |
| Sandro 🐧 | Why are we not using a standard path like something in /nix/var/nix/profiles/system/? Then we would not need to link that ourself. | 12:42:19 |
| Sandro 🐧 | I mean the updater in itself is a bad idea. NixOS can be configured in so many different ways especially with flakes that it will break for a good chunk of people and I don't want to accumulate all kinds of workarounds for that. | 12:43:20 |
 K900 | When would the updater be triggered anyway? | 12:44:23 |
| Arson Copperflame | When you run the script or nixos.exe update | 12:44:49 |
| K900 | Maybe we should just make it link to some upgrade guide | 12:44:52 |
| K900 | So it's not required for anything external? | 12:45:04 |
| K900 | Then I'd say just drop it honestly | 12:45:12 |
| K900 | It's way too difficult to get correctly in the general case | 12:45:21 |
| Arson Copperflame | It will obviously never work if you import the module yourself, all it does is replace the files in /etc/nixos/nixos-wsl and offer you to run nixos-rebuild switch(if it doesn't detect that you aren't using /etc/nixos/configuration.nix)
If your config comes from anywhere else, it does absolutely nothing. I don't see a way how you could break your system with it in a way that you couldn't by putting the files there manually | 12:50:13 |
| K900 | Maybe we should just default to generating the system config with flakes or even something like niv | 12:51:43 |
| K900 | So there's an obvious way to update all the inputs | 12:51:51 |
| Arson Copperflame | The idea is that when the MS Store (once we're on there) pushes a new version of the launcher to your device, it prompts you to run nixos update to use the version of our module that comes bundled with the launcher. It will however only do that, if NixOS-WSL-version outputs a version string, which it won't do if the version of the module you are running was pulleys from git | 12:52:45 |
| Arson Copperflame | * The idea is that when the MS Store (once we're on there) pushes a new version of the launcher to your device, it prompts you to run `nixos update` to use the version of our module that comes bundled with the launcher. It will however only do that, if NixOS-WSL-version outputs a version string, which it won't do if the version of the module you are running was pulled from git | 12:52:55 |
| Arson Copperflame | Using flakes by default would make some people really upset, that's why we don't do that | 12:55:30 |
| K900 | The launcher isn't coupled to the modules in any way though? | 12:55:40 |
| K900 | At least currently | 12:55:43 |
| K900 | Like, you can update the launcher and not update the modules, or vice versa, and it'll be fine | 12:55:55 |
| Arson Copperflame | Yes, that will work | 12:56:07 |
| K900 | So it feels weird to me to specifically prompt people to update when the launcher updates | 12:56:21 |
| Arson Copperflame | You can also use the updater without the launcher | 12:56:29 |
| Arson Copperflame | They are coupled in a way: The launcher comes with the installer tarball bundled. So whenever there's a new release, we need to push a new launcher to the store | 12:57:52 |
| Arson Copperflame | And both carry the same version number. The launcher checks the output of nixos-wsl-version and compares that to its own version number. If the module comes from anywhere except /etc/nixos/nixos-wsl, it would be DEV_BUILD and no update prompt would be triggered (because it can't know about /etc/nixos/nixos-wsl/VERSION) | 13:01:35 |
| Sandro 🐧 | In reply to @nzbr:nzbr.de
It will obviously never work if you import the module yourself, all it does is replace the files in /etc/nixos/nixos-wsl and offer you to run nixos-rebuild switch(if it doesn't detect that you aren't using /etc/nixos/configuration.nix)
If your config comes from anywhere else, it does absolutely nothing. I don't see a way how you could break your system with it in a way that you couldn't by putting the files there manually Why do we even do this?
Can't we just fetch the source from github? With flakes or just fetch* something?
| 13:04:31 |
