| 18 Oct 2025 |
 matthewcroughan | Who merged the PRs and reviewed the PRs though? | 12:42:31 |
 Alyssa Ross | package maintainers mostly | 12:42:54 |
| Alyssa Ross | I always tried to make very sure that PRs were merge-ready when I opened them | 12:43:08 |
| Alyssa Ross | in many cases, there were no Nixpkgs PRs | 12:43:40 |
| Alyssa Ross | because I got things fixed upstream | 12:43:44 |
| Alyssa Ross | and just waited for Nixpkgs to update | 12:43:50 |
| matthewcroughan | I see, yeah so like I said if I find any more things like that I'll just make it a draft PR instead of an open one | 12:44:12 |
| Alyssa Ross | I tried to make it so that other people had to spend as little time thinking about musl as possible | 12:44:40 |
| Alyssa Ross | (this did mean a lot of suffering in silence, because at the time there wasn't really anybody else around who cared — nowadays fortunately that's not true and we can help each other.) | 12:46:11 |
| Alyssa Ross | often I just had to put some stuff down until I had acquired more experience with simpler fixes and could come back to it later | 12:46:46 |
 dramforever | did i ever give you the patch for fb-re2 | 12:54:00 |
| matthewcroughan | I might have missed it, the thing you sent me on email was the upstream musl one right? | 12:54:39 |
| dramforever | yeah that's on the mailing list | 12:55:10 |
| matthewcroughan | You gave me a compare link to github I vaguely remember, I must have been busy on some other task at the time | 12:55:27 |
| matthewcroughan | https://github.com/facebook/pyre2/compare/main...dramforever:pyre2:fix-py3-type this? | 12:57:36 |
| dramforever | yeah | 12:57:45 |
| dramforever | i think this one might be a good candidate to remove dependence on | 12:58:15 |
| dramforever | might | 12:58:29 |
| matthewcroughan | Yeah Nix depends on it because of dependency on Mercurial for the functional tets | 12:58:49 |
| matthewcroughan | * Yeah Nix depends on it because of dependency on Mercurial for the functional tests | 12:58:51 |
| dramforever | i don't have any concrete reason for why it's bad other than it looking crusty | 12:59:02 |
| matthewcroughan | but I believe it works fine without re2SUpport | 12:59:20 |
| matthewcroughan | * but I believe it works fine without re2Support | 12:59:24 |
| matthewcroughan | and it's optional | 12:59:26 |
| matthewcroughan | (mercurial that is) | 12:59:34 |
| matthewcroughan | https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/me/mercurial/package.nix#L9 | 12:59:42 |
| dramforever | or maybe we could get a better fork of pyre2 | 13:00:25 |
| dramforever | why don't we just make mercurial use google-re2 | 13:08:31 |
| matthewcroughan | https://github.com/NixOS/nixpkgs/pull/451665 | 13:36:48 |
| matthewcroughan | Weird, this one still fails on Nix specifically | 13:36:55 |
