| 17 Aug 2025 |
Grimmauld (any/all) | so, not much i can help rn, sorry | 20:13:51 |
QuadRadical (Ping) | oh no | 20:13:55 |
QuadRadical (Ping) | no worries, all good :) | 20:14:02 |
Grimmauld (any/all) | something about gobject-introspection failing to link zlib | 20:14:33 |
QuadRadical (Ping) | hmm https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/in/iniparser/package.nix#L71 | 20:15:05 |
QuadRadical (Ping) | weird... | 20:15:10 |
QuadRadical (Ping) | i didnt get that | 20:15:13 |
QuadRadical (Ping) | maybe staging only | 20:15:18 |
Artturin | gir itself should cross-compile fine | 20:15:20 |
Artturin | At least I fixed it the last time | 20:15:31 |
Grimmauld (any/all) | doesn't, on current staging-next | 20:15:35 |
QuadRadical (Ping) | ruby is in nativeCheckInputs | 20:16:04 |
Artturin | nativeCheckInputs only runs on native | 20:16:35 |
Artturin | * tests only run on native | 20:16:51 |
Artturin | So either it isn't conditionalized right in the source itself, or it should actually be a nativeBuildInput | 20:17:24 |
QuadRadical (Ping) | hmm okay | 20:18:11 |
Grimmauld (any/all) | diff --git a/pkgs/development/libraries/gobject-introspection/default.nix b/pkgs/development/libraries/gobject-introspection/default.nix
index d461983e8d06..b58b8f2b70ed 100644
--- a/pkgs/development/libraries/gobject-introspection/default.nix
+++ b/pkgs/development/libraries/gobject-introspection/default.nix
@@ -2,7 +2,7 @@
stdenv,
lib,
fetchurl,
- fetchpatch,
+ zlib,
glib,
flex,
bison,
@@ -103,6 +103,7 @@ stdenv.mkDerivation (finalAttrs: {
buildInputs = [
(python3.withPackages pythonModules)
+ zlib
];
nativeCheckInputs = lib.optionals stdenv.hostPlatform.isDarwin [
seems to fix gobject-introspection on cross, but i'll not dig into that today
| 20:18:51 |
Grimmauld (any/all) | (the fetchpatch was unused) | 20:19:03 |
QuadRadical (Ping) | so do you suggest i take it out of nativeCheckInputs and put it into nativeBuildInputs? | 20:19:19 |
Artturin | cmakeFlags = [
(lib.cmakeBool "BUILD_TESTING" finalAttrs.doCheck)
];
nix-repl> pkgsCross.aarch64-multiplatform.iniparser.cmakeFlags
[
"-DBUILD_TESTING:BOOL=TRUE"
...
nix-repl> pkgsCross.aarch64-multiplatform.iniparser.doCheck
false
| 20:19:24 |
Artturin | The conditional is wrong | 20:19:34 |
Artturin | it should be finalAttrs.finalPackage.doCheck | 20:19:41 |
QuadRadical (Ping) | ahh | 20:19:56 |
Grimmauld (any/all) | its an easy mistake, i suspect i have a couple packages where i fell into the same trap | 20:20:15 |
Artturin | because finalAttrs does not contain the change done to doCheck in mkDerivation https://github.com/NixOS/nixpkgs/blob/a81d50424b14ddf51ad010ef01cd73476afe95d0/pkgs/stdenv/generic/make-derivation.nix#L322 | 20:20:18 |
Artturin | https://github.com/NixOS/nixpkgs/pull/434550 | 20:24:59 |
Grimmauld (any/all) | yep, you caught me, apparmor-parser is my packager lol | 20:25:56 |
Alyssa Ross | In reply to @artturin:matrix.org https://github.com/NixOS/nixpkgs/pull/434550 Pretty sure this won't eval | 20:26:46 |
Alyssa Ross | If you make outputs conditional on it you can infrec last I checked | 20:27:01 |
Grimmauld (any/all) | oh shit i did it twice, i made the same mistake in z3... | 20:27:11 |