| 14 Jul 2025 |
emily | but the PKG_CONFIG_PATH thing is at least not-as-wrong hopefully | 01:25:55 |
QuadRadical (Ping) | I should probably do that for now then, right? | 01:26:09 |
emily | it's at least less confusing imo | 01:26:24 |
emily | since it does not involve duplicating udev | 01:26:29 |
QuadRadical (Ping) | ill do it now | 01:26:31 |
QuadRadical (Ping) | thanks! | 01:26:40 |
Artturin | Could be something wonky here https://github.com/stratis-storage/devicemapper-rs/blob/59e04984047cba0be7ea743c826bf825ddc7989e/devicemapper-rs-sys/build.rs#L30 | 01:33:30 |
emily | so apparently they only use it for includes and not libraries | 01:34:06 |
emily | and someone added the disable_cargo_metadata feature to avoid the pkg_config crate telling Cargo how to link with the library because they were having cross issues | 01:34:25 |
emily | but AFAICT the pkg_config crate is meant to handle cross-compilation properly, so at most we should need a "useless" lvm2 dep for build platform | 01:34:44 |
emily | it will read target-suffixed env variables | 01:34:55 |
emily | otoh we also PKG_CONFIG_ALLOW_CROSS = if stdenv.buildPlatform != stdenv.hostPlatform then 1 else 0; which apparently disables its logic for detecting when you're doing cross right | 01:35:15 |
emily | so I rather suspect we are failing to set the variables it expects and our Rust + pkg-config + cross story is just kind of broken in general right now? | 01:35:42 |
emily | I am not entirely sure how pkg-config cross in Nixpkgs in general is meant to work though. (e.g. do you want a separate pkg-config dep for each platform you need to use it on?) | 01:36:27 |
emily | (use it "for" I suppose I should say) | 01:41:22 |
QuadRadical (Ping) | btw i changed it to use the other on e | 01:41:33 |
QuadRadical (Ping) | * btw i changed it to use the other one | 01:41:44 |
QuadRadical (Ping) | i dont know what the proper solution nis though | 01:42:04 |
colemickens 🏳️🌈 | (the latest version doesn't work for me, native or cross, from what I can tell) | 05:43:18 |
QuadRadical (Ping) | You're talking about my PR or? | 13:26:45 |
QuadRadical (Ping) | It builds fine for me | 13:26:50 |
QuadRadical (Ping) | Unless you mean it doesn't work properly but does build | 13:27:03 |
QuadRadical (Ping) | oh wait youre right | 13:30:26 |
QuadRadical (Ping) | setting PKG_CONFIG_PATH appears to make it only build with cross | 13:30:52 |
QuadRadical (Ping) | yeah it fails about udev otherwise | 13:35:10 |
QuadRadical (Ping) | i think the other way was better then | 13:35:15 |
emily | that is probably because of our dodgy PKG_CONFIG_ALLOW_CROSS setting | 13:46:49 |
emily | the other way is really not mergeable, we do not want a udev dependency that is not even used | 13:47:15 |
emily | it's just a hack around only having the wrong-platform pkg-config | 13:47:22 |
QuadRadical (Ping) | oh ok | 13:47:35 |