| 18 Jul 2025 |
QuadRadical (Ping) | so, not my fault then? | 20:40:34 |
emily | yes, I think Alyssa's patch is not quite right | 20:42:42 |
QuadRadical (Ping) | okay thanks! | 20:42:52 |
QuadRadical (Ping) | ill test again if its changed | 20:42:58 |
dramforever | oh hi we're doing the pkg-configening? | 20:44:33 |
emily | Alyssa Ross: er, it looks like it only even looks at the target-specific env variables specifically for the host platform (what it calls the target platform, Rust ecosystem should be punished for a thousand years for perpetuating that off-by-one error) | 20:45:31 |
emily | for the build platform it'll just always use unprefixed pkg-config | 20:45:38 |
emily | that's annoying | 20:45:42 |
emily | but I guess shouldn't break anything | 20:46:00 |
dramforever | yuuup... | 20:46:31 |
dramforever | that should work in nixpkgs though | 20:46:39 |
emily | everything everywhere is so hopelessly confused about cross | 20:46:41 |
dramforever | we don't do canadian cross | 20:46:52 |
emily | it's like when things try to think about cross they get even more confused | 20:46:58 |
dramforever | and also can't make a (L, C, C) compiler build other packages | 20:47:04 |
emily | yes, it just means we're always setting a "useless" thing | 20:47:13 |
emily | like the PKG_CONFIG_[buildPlatform] var is never useful | 20:47:24 |
emily | it might also mean we need to set PKG_CONFIG | 20:47:46 |
dramforever | i don't think it's cleaner to leave that out? | 20:47:48 |
emily | or HOST_PKG_CONFIG or whatever | 20:47:49 |
dramforever | so, whatever | 20:47:51 |
emily | because it looks for a relevant var when doing cross | 20:47:57 |
emily | but the logic is kind of tangled | 20:48:02 |
emily | let kind = if host == target { "HOST" } else { "TARGET" };
it's wonderful that it does this for no apparent reason
| 20:48:18 |
emily | I guess to handle the build script deps case | 20:48:26 |
dramforever | what uses HOST_PKG_CONFIG | 20:48:29 |
emily | so actually setting both should be fine⦠| 20:48:34 |
dramforever | does build script dep even look like cross | 20:48:44 |
emily | no, which is why ^ triggers | 20:48:53 |
emily | here's the relevant pieces of code https://docs.rs/pkg-config/0.3.32/src/pkg_config/lib.rs.html#638-659, https://docs.rs/pkg-config/0.3.32/src/pkg_config/lib.rs.html#606-630, https://docs.rs/pkg-config/0.3.32/src/pkg_config/lib.rs.html#672-679 | 20:49:06 |