| 17 Aug 2025 |
 Artturin | * tests only run on native | 20:16:51 |
| Artturin | So either it isn't conditionalized right in the source itself, or it should actually be a nativeBuildInput | 20:17:24 |
 QuadRadical (Ping) | hmm okay | 20:18:11 |
 Grimmauld (any/all) | diff --git a/pkgs/development/libraries/gobject-introspection/default.nix b/pkgs/development/libraries/gobject-introspection/default.nix
index d461983e8d06..b58b8f2b70ed 100644
--- a/pkgs/development/libraries/gobject-introspection/default.nix
+++ b/pkgs/development/libraries/gobject-introspection/default.nix
@@ -2,7 +2,7 @@
stdenv,
lib,
fetchurl,
- fetchpatch,
+ zlib,
glib,
flex,
bison,
@@ -103,6 +103,7 @@ stdenv.mkDerivation (finalAttrs: {
buildInputs = [
(python3.withPackages pythonModules)
+ zlib
];
nativeCheckInputs = lib.optionals stdenv.hostPlatform.isDarwin [
seems to fix gobject-introspection on cross, but i'll not dig into that today
| 20:18:51 |
| Grimmauld (any/all) | (the fetchpatch was unused) | 20:19:03 |
| QuadRadical (Ping) | so do you suggest i take it out of nativeCheckInputs and put it into nativeBuildInputs? | 20:19:19 |
| Artturin | cmakeFlags = [
(lib.cmakeBool "BUILD_TESTING" finalAttrs.doCheck)
];
nix-repl> pkgsCross.aarch64-multiplatform.iniparser.cmakeFlags
[
"-DBUILD_TESTING:BOOL=TRUE"
...
nix-repl> pkgsCross.aarch64-multiplatform.iniparser.doCheck
false
| 20:19:24 |
| Artturin | The conditional is wrong | 20:19:34 |
| Artturin | it should be finalAttrs.finalPackage.doCheck | 20:19:41 |
| QuadRadical (Ping) | ahh | 20:19:56 |
| Grimmauld (any/all) | its an easy mistake, i suspect i have a couple packages where i fell into the same trap | 20:20:15 |
| Artturin | because finalAttrs does not contain the change done to doCheck in mkDerivation https://github.com/NixOS/nixpkgs/blob/a81d50424b14ddf51ad010ef01cd73476afe95d0/pkgs/stdenv/generic/make-derivation.nix#L322 | 20:20:18 |
| Artturin | https://github.com/NixOS/nixpkgs/pull/434550 | 20:24:59 |
| Grimmauld (any/all) | yep, you caught me, apparmor-parser is my packager lol | 20:25:56 |
 Alyssa Ross | In reply to @artturin:matrix.org
https://github.com/NixOS/nixpkgs/pull/434550 Pretty sure this won't eval | 20:26:46 |
| Alyssa Ross | If you make outputs conditional on it you can infrec last I checked | 20:27:01 |
| Grimmauld (any/all) | oh shit i did it twice, i made the same mistake in z3... | 20:27:11 |
| Artturin | Worked in the previous treewide https://github.com/NixOS/nixpkgs/pull/271241 | 20:27:18 |
| Artturin | But let's see | 20:27:20 |
| Alyssa Ross | It failed | 20:27:26 |
| Artturin | oh :P | 20:27:34 |
| Artturin | Smh of course it's cuda | 20:28:08 |
| Grimmauld (any/all) | /nix/store/w6948hrs887n51sfj6shmpsgrcj62xgi-qemu-user-10.0.3/bin/qemu-aarch64: error while loading shared libraries: libz.so.1: cannot open shared object file: No such file or directory - turns out it wasn't gobject-introspection itself failing to laod libz, but rather a qemu it somehow pulls along the way? This is pain | 20:30:13 |
 emily | it's always CUDA | 20:30:18 |
| QuadRadical (Ping) | lint also fairs seeminlgy, due to infinite recursion/ | 20:30:59 |
| QuadRadical (Ping) | * lint also fairs seeminlgy, due to infinite recursion? | 20:31:02 |
| Artturin | One way to fix it is to do doCheck = stdenv.buildPlatform.canExecute stdenv.hostPlatform, then finalAttrs.doCheck will be right | 20:31:55 |
| Artturin | Doing that | 20:38:16 |
| Artturin | As it's what should be done anyways so the conditional in mkDerivation could be removed at some point like ericson has wanted since at least 2018 | 20:39:11 |
| QuadRadical (Ping) | @Artturin do you mind me bugging you with one more question? | 21:34:55 |
