| 18 Oct 2025 |
dramforever | did i ever give you the patch for fb-re2 | 12:54:00 |
matthewcroughan | I might have missed it, the thing you sent me on email was the upstream musl one right? | 12:54:39 |
dramforever | yeah that's on the mailing list | 12:55:10 |
matthewcroughan | You gave me a compare link to github I vaguely remember, I must have been busy on some other task at the time | 12:55:27 |
matthewcroughan | https://github.com/facebook/pyre2/compare/main...dramforever:pyre2:fix-py3-type this? | 12:57:36 |
dramforever | yeah | 12:57:45 |
dramforever | i think this one might be a good candidate to remove dependence on | 12:58:15 |
dramforever | might | 12:58:29 |
matthewcroughan | Yeah Nix depends on it because of dependency on Mercurial for the functional tets | 12:58:49 |
matthewcroughan | * Yeah Nix depends on it because of dependency on Mercurial for the functional tests | 12:58:51 |
dramforever | i don't have any concrete reason for why it's bad other than it looking crusty | 12:59:02 |
matthewcroughan | but I believe it works fine without re2SUpport | 12:59:20 |
matthewcroughan | * but I believe it works fine without re2Support | 12:59:24 |
matthewcroughan | and it's optional | 12:59:26 |
matthewcroughan | (mercurial that is) | 12:59:34 |
matthewcroughan | https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/me/mercurial/package.nix#L9 | 12:59:42 |
dramforever | or maybe we could get a better fork of pyre2 | 13:00:25 |
dramforever | why don't we just make mercurial use google-re2 | 13:08:31 |
matthewcroughan | https://github.com/NixOS/nixpkgs/pull/451665 | 13:36:48 |
matthewcroughan | Weird, this one still fails on Nix specifically | 13:36:55 |
matthewcroughan | like Nix itself, fails to build, but the derivation alone is fine | 13:37:04 |
matthewcroughan |  Download image.png | 13:37:16 |
matthewcroughan | like, is Nix itself overriding perl in some way to make this fail Alyssa Ross ? | 13:37:24 |
matthewcroughan | The code in pkgs/tools/package-management/nix/common-meson.nix looks pretty hacky | 13:37:50 |
matthewcroughan | Like it appears there are even two DBIs instantiated there in the graph | 13:38:13 |
matthewcroughan | to get a pkgs.nixos {} to compile with musl I had to nix.enable = false is the context here | 13:40:25 |
matthewcroughan | I'll make it simpler by just doing the native musl case where it fails too | 13:41:37 |
matthewcroughan | Ah, in that case the following happens, so it fails differently
> check flags: SHELL=/nix/store/idi6v58lxi4qp6l41n7w6914ggpxnmqr-bash-5.3p3/bin/bash VERBOSE=y test
┃ > "/nix/store/aqnlwa4lky3sf8mrzzdvi0d8mmc3g3ni-perl-5.40.0/bin/perl" -MExtUtils::Command::MM -e 'cp_nonempty' -- DBI.bs blib/arch/auto/DBI/DBI.bs 644
┃ > PERL_DL_NONLAZY=1 "/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
┃ > /nix/store/idi6v58lxi4qp6l41n7w6914ggpxnmqr-bash-5.3p3/bin/bash: line 1: /bin/perl: No such file or directory
┃ > make: *** [Makefile:1435: test_dynamic] Error 127
┃ For full logs, run:
┃ nix log /nix/store/b6chj56gypfcy72xikpga7qqg841qarc-perl5.40.0-DBI-1.644.drv
| 13:42:00 |
matthewcroughan | Alyssa Ross: That's great! I see your splicing fixed one thing but showed this error up | 13:48:37 |
matthewcroughan | The above /bin/perl not found issue happens when I apply your patch https://github.com/NixOS/nixpkgs/pull/452642#discussion_r2437030777 | 13:48:53 |