24 Aug 2025 |
hexa | yup, but it also fixed the native build | 18:58:43 |
hexa | sorry if it broke cross | 18:58:46 |
dramforever | no, it also broke native | 18:58:54 |
dramforever | qemu-user, specifically | 18:59:00 |
tpw_rules | it fixed the build but the resulting binary doesn't work | 18:59:01 |
hexa | it worked on python-updates | 18:59:04 |
Alyssa Ross | qemu-user did? | 18:59:08 |
hexa | ok | 18:59:08 |
tpw_rules | it didn't | 18:59:12 |
hexa | the build worked, I did not test qemu | 18:59:22 |
dramforever | qemu still worked, qemu-user didn't work | 18:59:23 |
hexa | ok | 18:59:27 |
dramforever | so, anyway, any reason to wrap instead of python3Packages like before? | 18:59:50 |
hexa | feel free to unwrap, I'm honestly not sure how python environments compose without | 19:00:12 |
tpw_rules | yes dram can confirm that patch works | 19:00:29 |
tpw_rules | i'm not sure what exactly in the python updates changed to make distlib mandatory, i sort of got halfway there in bisecting | 19:00:50 |
tpw_rules | but it's definitely that PR somewhere | 19:01:17 |
tpw_rules | guess this also makes artturin's earlier PR redundant? | 19:01:42 |
tpw_rules | or does that still need to be mixed in somehow? | 19:01:49 |
dramforever | quick q how do i retract a request changes | 19:02:42 |
dramforever | that hasn't been merged, i think we just move that to the new fix | 19:02:56 |
dramforever | * quick q how do i retract a request changes on github | 19:03:04 |
tpw_rules | i think all you can do is approve it | 19:03:11 |
tpw_rules | your request doesn't matter though since you don't have the commit bit | 19:03:20 |
tpw_rules | (nor does your approval) | 19:03:23 |
dramforever |  Download Screenshot_20250825_030355.png | 19:04:01 |
dramforever | yeah i just wanted to get rid of this but i guess i requested changes the new patch anyway | 19:04:10 |
Alyssa Ross | you can dismiss the review | 19:05:47 |
Alyssa Ross | it's in that same box | 19:05:53 |
Alyssa Ross | that you screenshotted | 19:05:58 |