| 16 Oct 2025 |
 matthewcroughan | nix build github:matthewcroughan/nixos-musl/refactor#nixosConfigurations.gnu-musl.config.system.build.vm | 15:40:21 |
| matthewcroughan | dramforever: 👏 | 15:40:31 |
| matthewcroughan | It worked | 15:40:32 |
| matthewcroughan | Still nobody to review my PRs that I'm holding as patches in my own repo | 15:43:59 |
| matthewcroughan | I've tested them pretty extensively, they're working, and they just live in https://github.com/MatthewCroughan/nixos-musl/blob/refactor/musl.nix#L80-L119 | 15:44:55 |
 dramforever | nice | 15:56:33 |
| dramforever | if it looks like nothing else has broke i'll send it to musl | 15:56:45 |
| dramforever | or maybe think harder about how to deal with arch specific code | 15:56:58 |
| matthewcroughan | Just make it crash with -95 on every platform except for aarch64 😎 | 15:58:18 |
| dramforever | i already made it fall back to old behavior for unimplemented architectures | 15:59:00 |
| matthewcroughan | That is an ouch... | 15:59:34 |
| matthewcroughan | It should at least report or mark that it is broken | 15:59:41 |
| matthewcroughan | otherwise that's just some form of silent bug that breaks other arches | 15:59:49 |
| matthewcroughan | I think there should be some messaging somewhere | 16:00:03 |
| matthewcroughan | Can we carry this musl patch in nixpkgs until they merge it? | 16:00:17 |
| dramforever | no | 16:00:37 |
| matthewcroughan | I think this is equivalent to how we patch many things, like kmod or systemd because we need recursion | 16:00:38 |
| matthewcroughan | * I think this is equivalent to how we patch many things, like kmod or systemd because we need recursion and lists | 16:00:43 |
| matthewcroughan | I don't see how this patch is any more or less relevant than some of the kmod or systemd patches we carry | 16:00:58 |
| matthewcroughan | BTW, if you feel like more hacking, kmod needs to be version bumped, and that patch is crazy | 16:01:17 |
| matthewcroughan | https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/os-specific/linux/kmod/module-dir.patch | 16:01:33 |
| matthewcroughan | This makes kmod accept a list of arguments instead of a hardcoded fhs dir | 16:02:04 |
| matthewcroughan | necessary for nixos, similar to your musl patch :) | 16:02:11 |
| matthewcroughan | And we're 3 versions behind on kmod because they've moved to meson, and this patch isn't upstreamed | 16:02:55 |
| dramforever | vendoring my musl patch in nixpkgs is a violation of https://do-not-ship-work-in-progress.gitlab.io/ | 16:03:59 |
| matthewcroughan | Is it any more or less WIP than the kmod patch? | 16:04:31 |
| dramforever | the kmod module-dir.patch doesn't apply because it's nixos specific | 16:04:34 |
| dramforever | so we can't not ship it in nixpkgs | 16:04:44 |
| matthewcroughan | i would argue that the musl patch is nixos specific too, at least I'm sure when you upstream it someone might say something like that | 16:04:54 |
| matthewcroughan | It's a bit of a blurry line | 16:05:12 |
