| 17 Oct 2025 |
 matthewcroughan | like, yes, there are crazy combos, but musl always means the libc is musl right? | 04:20:21 |
 ElvishJerricco | yes, but like I've said already, the condition is not about musl | 04:20:53 |
| ElvishJerricco | musl / glibc is not a binary | 04:20:58 |
| ElvishJerricco | it's not one or the other | 04:21:00 |
| ElvishJerricco | the thing we care about here is if the libc is literally glibc. Is it clear that "not musl" is not equal to "is glibc"? | 04:21:22 |
| ElvishJerricco | because "is glibc" is the correct semantics | 04:21:27 |
| matthewcroughan | I wonder now how hostPlatform.libc even gets defined | 04:21:49 |
| ElvishJerricco | https://github.com/NixOS/nixpkgs/blob/ff84020dd9cc87bab5c2675d62e555afeb09304f/lib/systems/default.nix#L120 | 04:22:09 |
| matthewcroughan | like what comes first, isMusl = or libc = | 04:22:11 |
| ElvishJerricco | now, admittedly, that code is a little flawed, in that it assumes that if any of those other conditions isn't true then it should fallback to glibc, but that's its own bug and not relevant to using the correct semantics in this PR | 04:22:52 |
| matthewcroughan | Okay so the libc is itself defined in terms of isMusl | 04:22:54 |
| ElvishJerricco | among a big list of other things | 04:23:08 |
| matthewcroughan | so isMusl seems to come firt? | 04:23:08 |
| matthewcroughan | * so isMusl seems to come first? | 04:23:10 |
| ElvishJerricco | do you see all those other conditions? | 04:23:17 |
| ElvishJerricco | Is it clear that musl and glibc are not the only possible libc? | 04:23:38 |
| matthewcroughan | IDK what semantics are | 04:23:48 |
| matthewcroughan | you seem to be 200% more informed than I am | 04:23:53 |
| ElvishJerricco | it's truly this simple: the platform can be using any libc in the world. Only in the glibc platform do we want to do this condition. | 04:24:18 |
| matthewcroughan | Yes, but as far as I understood musl is a libc, and isMusl should be equivalent to libc == musl | 04:24:28 |
| ElvishJerricco | ....... which is not inverse to libc == glibc | 04:24:49 |
| ElvishJerricco | which is the whole point | 04:24:53 |
| matthewcroughan | Yes, and your suggestion reads better, I'm just trying to learn a bit more | 04:25:01 |
| ElvishJerricco | the thing should not evaluate to true if some non-glibc, non-musl thing is libc | 04:25:10 |
| matthewcroughan | ah that's the example I didn't get, makes more sense now | 04:25:27 |
 dramforever | i'm sending it soon, do you have an address you want to get a cc on? | 10:08:32 |
| dramforever | i sent it to your git commit address, hope you like email | 10:51:20 |
| dramforever | if you don't uhhhh block it or something | 10:51:48 |
| matthewcroughan | I got it, thank you! | 11:30:25 |
| 18 Oct 2025 |
| matthewcroughan | https://hercules-ci.com/accounts/github/MatthewCroughan/derivations/%2Fnix%2Fstore%2F5nnc4v6x94pq0k9vrl8pb69zwjj0518l-valgrind-aarch64-unknown-linux-musl-3.25.1.drv/log?via-job=d5388d69-831d-4a05-b861-7ad9d634b548 | 01:46:33 |
