| 9 Jan 2025 |
 Greg Hellings | icuReal = icu74;
icu = if stdenv.hostPlatform.isDarwin then darwin.ICU else icuReal;
| 22:48:00 |
| Greg Hellings | That's different from master where it is just icu = icu74;, but still not revving it to 76 | 22:48:22 |
 K900 | Oh OK | 22:49:02 |
| K900 | Then I guess we'll have to update it eventually | 22:49:15 |
| K900 | I guess it can be done conditionally on mingw but I'd rather just update it everywhere | 22:49:27 |
| Greg Hellings | Updating it everywhere sounds like a job for staging next, and not me randomly proposing a change to master. 😆 | 22:49:59 |
| Greg Hellings | Currently testing the ucrt Windows build to see if it is limited to MinGW or if it's all Windows. The way I understand the bug and the code I'm seeing it should be MinGW specific | 22:50:36 |
| Greg Hellings | Yeah, ucrt with CLang builds fine with ICU74 | 22:50:53 |
| K900 | In reply to@greg:thehellings.com
Updating it everywhere sounds like a job for staging next, and not me randomly proposing a change to master. 😆 Yes | 22:51:13 |
| Greg Hellings | Wait, no, that was me building ucrt with icu76. Trying again with 74 | 22:51:32 |
| Greg Hellings | OK, yeah, this is limited to only failing on MinGW as I thought. The naughty code is behind ifdef's for MinGW, so that's expected | 22:53:09 |
| Greg Hellings | Should I prepare a limited PR for master to just rev it for mingw? Or is staging updating it everywhere in the near future? | 22:54:49 |
| K900 | In reply to@greg:thehellings.com
Should I prepare a limited PR for master to just rev it for mingw? Or is staging updating it everywhere in the near future? I would prefer the latter | 22:58:32 |
| K900 | Any sort of "this obscure platform uses this other thing instead of the normal thing" conditionals explode given enough time | 22:58:52 |
| Greg Hellings | Agreed. I don't know about calling Windows obscure, but it's definitely a corner case for nixpkgs | 23:00:42 |
| K900 | Windows is not obscure | 23:06:02 |
| K900 | MinGW is, extremely | 23:06:07 |
| 10 Jan 2025 |
 emily | don't we use MinGW for all Windows cross | 00:59:24 |
| K900 | In reply to @emilazy:matrix.org
don't we use MinGW for all Windows cross Yes, which we have very little of | 07:14:40 |
| Greg Hellings | Yes, but only with gcc on some of them. And the build failure is mingw+gcc-14+ specific. For ucrt targets we seem to use clang instead and that did not manifest the failure | 15:33:12 |
| Greg Hellings | K900: Is there any pomp and circumstance needed for submitting a PR to staging-next for that, or can I send one in? | 15:48:00 |
| K900 | You want to target staging | 15:49:09 |
| K900 | Not staging-next | 15:49:10 |
| K900 | And be ready to deal with the fallout | 15:49:19 |
| Greg Hellings | And, I presume, a mention in the release notes is worthy for this? | 15:49:36 |
| K900 | Probably yes | 15:50:48 |
| emily | if ICU version is going to drift from what Apple tracks we should maybe reconsider coupling darwin.ICU to it. cc Randy Eckenrode | 16:02:21 |
| K900 | Is darwin.ICU just the system version of ICU? | 16:03:05 |
| emily | it's a source build of the version Apple ships | 16:03:23 |
| emily | which is a fork of ICU with a bunch of changes | 16:03:27 |
