| 2 Dec 2024 |
kjeremy | Artturin: it's crazy to me how easily it is to get the evaluator to OOM with small changes on cross. I would expect memory usage to be linear wrt non-cross but it's definitely not | 15:26:27 |
Rick (Mindavi) | I think it instantiates nixpkgs x amount of times | 15:28:34 |
hexa | and don't try python things 🙈 | 16:12:19 |
kjeremy | hexa: the python thing is killing me with nix-ros-overlay | 16:13:09 |
hexa | but you surely remember the issue 😛 | 16:13:09 |
hexa | sowwy | 16:13:29 |
hexa | untangling this mess goes over my head | 16:13:42 |
| xin joined the room. | 16:20:21 |
| xin set a profile picture. | 16:27:15 |
Alexandros Liarokapis | In reply to @kjeremy:matrix.org hexa: the python thing is killing me with nix-ros-overlay Which python thing? | 16:49:36 |
Artturin | https://github.com/NixOS/nixpkgs/blob/9763b802cea94c20b3b85ea408bf5bf4dd1fcaf1/pkgs/development/interpreters/python/cpython/default.nix#L135 | 16:51:47 |
kjeremy | yep. the corresponding issue: https://github.com/NixOS/nixpkgs/issues/338231 | 16:53:47 |
Artturin | The comment in the code is wrong because it's not interacting with splicing in any way | 16:54:53 |
Artturin | * The comment in the code is wrong because it's not interacting with splicing from splice.nix in any way | 16:55:19 |
Artturin | it's kind of reimplementing splicing | 16:55:27 |
Artturin | * it's kind of reimplementing splicing
Override doesn't preserve splicing anyways | 16:56:13 |
szlend | if pkgs was already spliced, it would :> | 18:48:38 |
Artturin | It wouldn't | 18:48:57 |
szlend | Are you saying this wouldn't work? foo.override { bla = pkgs.__splicedPackages.bla; } | 18:50:29 |
Artturin | In reply to @artturin:matrix.org it's kind of reimplementing splicing Override doesn't preserve splicing anyways It doesn't preserve __spliced because those are not a part of the derivation/package, instead they're just tacked on to package attrset | 18:51:16 |
Artturin | x.override ...) ? __spliced == false | 18:51:49 |
Artturin | * __splicedPackages.x.override ...) ? __spliced == false | 18:51:56 |
szlend | oh right, that makes sense | 18:52:15 |
szlend | (pkgs.splicePackages { pkgsBuildBuild = pkgs.pkgsBuildBuild.override { ... }, ... }).foo :') | 18:53:43 |
szlend | * (pkgs.splicePackages { pkgsBuildBuild = pkgs.pkgsBuildBuild.foo.override { ... }, ... }).foo :') | 18:53:56 |
Artturin | Nah too cumbersome | 18:54:53 |
Artturin | https://github.com/NixOS/nixpkgs/blob/cbefb908e709b0579a3aca712614569952fec10e/lib/customisation.nix#L88 | 18:55:04 |
Artturin | Func like this | 18:55:30 |
Artturin | lib.overrideAttrs | 18:55:36 |
szlend | wait but doesn't .override call this exact function? | 18:57:55 |