| 17 Dec 2024 |
 Corngood | So this is something meant to build with an older SDK? You may just have to fix things like that unfortunately. | 22:24:51 |
| Corngood | Or maybe you just need to set an explicit language version? | 22:25:52 |
| Corngood |
CS9194: Argument may not be passed with the ref keyword. To pass ref arguments to in parameters, upgrade to language version 12 or greater.
| 22:26:38 |
 Whovian9369 | Yeah, I just remembered that it's originally a netcoreapp3.1 app and not a net7.0 one, so I have to manually substituteInPlace to go from one to the other to get it to build with net7.0. | 22:26:43 |
| Whovian9369 | * Yeah, I just remembered that it's originally a netcoreapp3.1 app and not a net7.0 one, so I have to manually substituteInPlace to go from one to the other to get it to build with net7.0. (Likely to get it to build in the first place, haha.) | 22:27:10 |
| Corngood | do the project files have LangVersion? | 22:27:28 |
 6pak | it does https://github.com/aaru-dps/Aaru/blob/v5.3.2/Aaru.Images/Aaru.Images.csproj#L20 | 22:27:58 |
| 6pak | no clue how it compiled in the first place | 22:28:02 |
| Corngood | maybe the have build scripts that override it or something? | 22:28:32 |
| Corngood | * maybe they have build scripts that override it or something? | 22:28:36 |
 Samuel | In reply to @6pak:matrix.org
it does https://github.com/aaru-dps/Aaru/blob/v5.3.2/Aaru.Images/Aaru.Images.csproj#L20 Huh that's cursed | 22:28:50 |
| Corngood | maybe try with -p:LangVersion=12.0 or latest | 22:29:12 |
| Whovian9369 | Trying with that, thank you! | 22:30:09 |
| Whovian9369 | Also thank you all so much for the thoughts here! | 22:30:18 |
| Corngood | So the v5.3.2 tag is what you're building? Looks like the main branch has newer LangVersion set. | 22:31:08 |
| 6pak | I assume you don't want a prerelease version for "Data Preservation Suite" | 22:31:49 |
| Corngood | I also don't really understand why it would have built before, but maybe the previous SDK was less strict about checking features or something? | 22:32:25 |
| 6pak | likely | 22:32:38 |
| 6pak | ref safety got a lot of changes recently | 22:32:48 |
| 6pak | but generally you get new warnings/errors when you switch to a newer langversion, not just the compiler | 22:33:11 |
| Corngood | So I guess you could either set LangVersion globally or patch the specific csproj | 22:33:30 |
| Corngood | May end up being a can of worms though | 22:33:44 |
 GGG | In reply to @corngood:corngood.com
I also don't really understand why it would have built before, but maybe the previous SDK was less strict about checking features or something? Could be some changes to overload resolution | 22:34:00 |
| GGG | They do those quite often afaik | 22:34:18 |
| Whovian9369 | Yeah, that's the lts version while the newer versions are WIP. If you look at my Flake, it's split into three versions - lts, prerelease, and git for experimentation in case people want to use specific versions.
https://github.com/Whovian9369/aaru-nix-flake/blob/main/flake.nix#L14 | 22:38:48 |
| Corngood | GGG, 6pak I am interested in the things you were discussing earlier. I'm not sure where to go with it exactly.
Runtime-specific nuget dependencies has been on my mind for a bit, but how do we get there? One way would be to clear $NUGET_PACKAGES between restoring each platform. And then you wouldn't want to bloat the deps file, so you'd also need to group them by runtime somehow.
| 22:39:12 |
| Corngood | * GGG, 6pak I am interested in the things you were discussing earlier. I'm not sure where to go with it exactly.
Runtime-specific nuget dependencies has been on my mind for a bit, but how do we get there? One way would be to clear $NUGET_PACKAGES between restoring each platform. And then you wouldn't want to bloat the deps file, so you'd also need to group them by runtime somehow.
... maybe we should make an issue to discuss that specifically, if one doesn't already exist.
| 22:39:30 |
| 6pak | imo step one is fetch-deps not restoring at all | 22:39:55 |
| 6pak | GenerateRestoreGraphFile looked like it had everything we need | 22:40:42 |
| 6pak | and it's what the dotnet cli uses for the package subcommand | 22:40:53 |
