| 18 May 2025 |
Whovian9369 | * patchPhase = ''
# Remove global.json to prevent build issues stemming from its existence.
# We're pinning to an SDK version by using Nix anyway, so it's not super
# important to worry about Upstream's set version.
rm global.json
'';
So this seems to have worked fine. Thank you again for the thoughts!
| 23:11:00 |
6pak | you probably want postPatch, but yeah, lgtm | 23:23:03 |
Whovian9369 | Oh, do you have a specific thought on why I should be using postPatch instead of patchPhase for this? | 23:23:37 |
Whovian9369 | I'm also doing more in patchPhase than just what I put above, so if you think moving that rm to postPatch instead is good then I'll probably just move the whole block. | 23:24:50 |
Whovian9369 | * I'm also doing more in patchPhase than just what I put above, so if you think moving that rm to postPatch instead is good then I'll probably just rename the whole block. | 23:24:58 |
6pak | overriding patchPhase will break patches iirc | 23:24:58 |
Whovian9369 | Eh fair, I'll probably split it into two commits (updating and then swapping to postPatch) - Thanks for the thoughts! | 23:26:04 |
| 27 May 2025 |
| @deeok:matrix.org joined the room. | 19:17:22 |
| 28 May 2025 |
| crgre joined the room. | 15:18:28 |