 | Nix + dotnet | 125 Members |
| 24 Servers |
| Nix + dotnet | 125 Members |
| 24 Servers |
| Sender | Message | Time |
|---|---|---|
| 17 Mar 2025 | ||
 Matt Sturgeon | * Am I missing something, or is To reproduce on latest master, wipe a deps.json file and attempt to re-generate it: No changes to add-nuget-deps in 3months, so I'm confused. Nothing obviously wrong in the built scripts either. | 22:47:16 |
 GGG | yeah, there's an open issue about it, curl now fails with --netrc flag and we add it unconditionally in nuget-to-json | 22:47:39 |
| GGG | corngood has a PR open on it, however it is also the same PR for the latest patch tuesday | 22:48:00 |
| Matt Sturgeon | Thanks, I should've checked for an issue. I'll try cherry-picking 7a36c0ef locally. Assuming #389338 won't merge for a while, is it worth opening another PR with just the curl fixes? | 22:53:56 |
| GGG | yes, it would be indeed preferable so we can merge and backport ASAP | 22:54:32 |
| GGG | do you agree Corngood? | 22:54:36 |
| Matt Sturgeon | * Thanks, I should've checked for an issue. I'll try cherry-picking 7a36c0ef locally. Assuming #389338 won't merge for a while, is it worth opening another PR with just the curl fixes?EDIT: that commit did resolve things for me | 22:55:00 |
 Corngood | It's good with me if someone wants to merge it on its own. I've been away this weekend so I haven't had a chance to work on the upgrades. | 23:11:19 |
 Whovian9369 | Hey gang, for some reason I'm not getting any deps.json output recently. I'm not sure if it's related to the error mentioned above by Matt or not? | 23:19:00 |
| GGG | Most likely yes | 23:19:12 |
| Whovian9369 | That's a little frustrating, damn. Thanks! | 23:19:37 |
| GGG | could probably temporarily solve it by doing touch ~/.netrc | 23:19:56 |
| Corngood | That'll work if you call `nuget-to-json` directly, but not for `fetch-deps` | 23:20:34 |
| GGG | oh? | 23:20:40 |
| Whovian9369 | Oh it depends on the local $HOME/.netrc (or is it the one in $TMPDIR/home)? | 23:21:42 |
| Corngood | Yeah, it creates a temporary $HOME I'm pretty sure. | 23:21:59 |
| Corngood | Cherry picking the fix is probably easiest for fetch-deps https://github.com/NixOS/nixpkgs/pull/389338/commits/7a36c0ef0b08e07afec4f5300956941db2945efa | 23:22:42 |
| Whovian9369 | Yeah but then that requires applying it in the derivation. What I did is cp fetch-deps fetch-deps.sh && chmod 600 fetch-deps.sh && chmod +x fetch-deps.sh, and added touch "$HOME/.netrc" under where it runs the mkdir. | 23:27:01 |
| Whovian9369 | That appears to have worked and let me generate deps.json -- Small/Temporarily manual patch that forces it to work, at least. | 23:27:55 |
| Whovian9369 | This seems to be the minimal diff to force it to work afaict | 23:29:47 |
| GGG | interesting, however considering something | 23:31:37 |
| GGG | this still breaks the use case for people using .netrc files | 23:31:44 |
| GGG | the temp home dir | 23:31:51 |
| Whovian9369 | Willing to please elaborate? | 23:32:52 |
| GGG | oh no, this is a whole separate issue, don't even worry about it | 23:33:05 |
| GGG | it's just that some people use .netrc files to connect to private nuget repos, and since we change $HOME in fetch-deps, that entirely breaks that use-case | 23:33:28 |
| GGG | but it's not related to your fix at all, it's a problem that already was in there to begin with | 23:33:49 |
| Whovian9369 | Ah okay, thanks! | 23:33:56 |
| Matt Sturgeon | So should the script copy ~/.netrc if it exists before it creates the temp home? Does it have to be ~/.netrc or can it also be configured at some other locations (e.g. XDG dirs)? | 23:37:40 |
| GGG | no idea, but that's probably another issue we have to open and then consider how to fix. | 23:38:06 |