| 10 Jan 2025 |
GGG | I know we already do, but it's pretty much not used in nixpkgs | 20:39:23 |
| 14 Jan 2025 |
Corngood | patchcil change: https://github.com/NixOS/nixpkgs/pull/373107 GGG This sounds cool. I'll probably have to wait until I have some downtime to wrap my head around it. I thought others here might be interested. | 13:56:59 |
GGG | Fair enough, it's not very complex but there are quite a few steps in the process so it's not something that easy to review | 13:58:42 |
GGG | Even more considering whoever reviews it will need to read and understand the patchcil source as well | 13:58:58 |
Waldemar Tomme | Hi, quick question (hopefully): I'm building a .NET package with buildDotnetModule and need two cli tools available. I tried buildInputs but this doesn't seem to work. How can I make the tools available to the dotnet tool? | 14:26:03 |
Emma [it/its] | nativeBuildInputs, iirc? | 14:26:49 |
Emma [it/its] | or dyou mean at runtime? | 14:26:58 |
Emma [it/its] | * or do you mean at runtime? | 14:27:02 |
Waldemar Tomme | at runtime | 14:27:02 |
Emma [it/its] | one sec | 14:27:19 |
Emma [it/its] | theres a separate thing for that but i need to look it up | 14:27:31 |
Emma [it/its] | runtimeDeps :) | 14:27:55 |
Waldemar Tomme | :/ i tried earlier and now as well but it only appends the /lib sub paths to LD_LIBRARY_PATH it seems | 14:29:52 |
Waldemar Tomme | otherwise I will wrap it but would like it if I can manage it with a single package | 14:31:16 |
Waldemar Tomme | or more like: I assumed it would be possible to just do it with buildDotnetModule | 14:32:09 |
Emma [it/its] | huh... thats odd | 14:33:14 |
Emma [it/its] | bins should be on PATH... i use runtimeDeps for yt-dlp (and transitively, ffmpeg) in a project | 14:34:01 |
Emma [it/its] | seems is misunderstood what runtimeDeps does | 14:36:29 |
Waldemar Tomme | in the source of buildDotnetModule runtimeDeps is only used to get libraries (https://github.com/NixOS/nixpkgs/blob/635e887b48521e912a516625eee7df6cf0eba9c1/pkgs/build-support/dotnet/build-dotnet-module/default.nix#L124) | 14:36:36 |
Waldemar Tomme | In the manual it also says that it's only for libraries | 14:37:04 |
Waldemar Tomme | guess I will make a wrapper | 14:37:14 |
GGG | You can use `makeWrapperArgs` to add stuff to path | 14:38:12 |
GGG | `buildDotnetModule` already makes a wrapper, so don't make a wrapper out of a wrapper | 14:50:18 |
Waldemar Tomme | It works now. thanks ^^ but small question for clarification: what are the default arguments for makeWrapper for?
# "--prefix"
# "LD_LIBRARY_PATH"
# ":"
# "${dotnet-sdk.icu}/lib"
| 14:58:26 |
GGG | .NET needs ICU for globalization features | 15:09:45 |
Waldemar Tomme | Don't think I'll need but re-add it so I don't need to in the (possible) future | 15:10:40 |
GGG | It should add them even if you set makeWrapperArgs | 15:13:25 |
Waldemar Tomme | oh, ok. then I maybe did not read the source correctly | 15:13:51 |
GGG | It adds them with `++`, so they'll always be added regardless | 16:01:52 |
GGG | Also, you may not think you use globalization, but even a simple `double.Parse` or `string.ToLower` uses globalization already (unless if you use invariant culture for everything) | 16:20:19 |